-
Notifications
You must be signed in to change notification settings - Fork 542
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic needs for this repo to be useful #5
Comments
(CLI) Conventions
Perhaps it doesn't have to be that way. I'd like to suggest the following;
It looks like we'll have several projects contributing stuff and a lot of people will want to expose running a test in a nice way with a cli and maybe even as a subcommand of their project. I know I want that. Aforementioned Click lets you compose these things pretty easily. For example, on @jeremyeder's side of things they have this runner that I could simply import as a subcommand if it were to adopt the convention. Exposing it in such a way is more user friendly than having users pull this repo and individually read and understand each subdirectory. Furthermore I think each cli should be able to parse a yaml config file (just like kubectl) that defines a test. See this webframework comparison benchmark for inspiration. In SummaryI should be able to pull this repo, cd into the subdirectory of interest, and have a cli.py wrapper I can immediately try out either against example yaml definitions or with my own flags. I should also easily be able to import into my own project whichever subdirectories of this repo I find relevant. Thoughts? |
Meeting occurred, notes were taken: |
@Zilman - there will be very different things here, e.g. running kubemark will be drastically different than running cluster-loader or dedicated component benchmarks and not all of them will have it's own CLI. Kubemark uses |
For the existing e2e tests(density, load) i.e. density test: |
@sjug is going to discuss the first part of this at the @kubernetes/sig-testing tomorrow, Tue Oct 4. And then in further depth at the @kubernetes/sig-scalability meeting on Thursday Oct 6, which we've agreed will own the "perf-tests" repo. |
Agreed. For the pods per core discussion, please move it to the original issue: kubernetes/kubernetes#25762 |
Issues go stale after 30d of inactivity. Prevent issues from auto-closing with an If this issue is safe to close now please do so with Send feedback to sig-testing, kubernetes/test-infra and/or |
At least:
The text was updated successfully, but these errors were encountered: