Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--wait, wait for more components #7375

Merged
merged 20 commits into from
Apr 4, 2020
Merged

--wait, wait for more components #7375

Changes from 1 commit
Commits
Show all changes
20 commits
Select commit Hold shift + click to select a range
f4950bc
break down kverify package to files
medyagh Apr 2, 2020
e4eae47
interpret wait flags
medyagh Apr 2, 2020
3b39b27
fix interpret wait
medyagh Apr 2, 2020
1df01b5
add wait
medyagh Apr 2, 2020
f49a7a2
add new wait logic to kubeadm
medyagh Apr 2, 2020
4c8f79d
add wait logic to kubeadm
medyagh Apr 2, 2020
d6b3cc6
lint
medyagh Apr 2, 2020
9fc36a6
typo
medyagh Apr 2, 2020
9335d28
fix the years
medyagh Apr 2, 2020
e18ce70
fix negated logic
medyagh Apr 2, 2020
89f2b9d
rename
medyagh Apr 3, 2020
86c9d2b
rename
medyagh Apr 3, 2020
62ca22a
refactor and rebase
medyagh Apr 3, 2020
5f6b547
add time out for wait for default sa
medyagh Apr 3, 2020
90c251d
lint
medyagh Apr 3, 2020
fa9d47a
reuse timeout
medyagh Apr 3, 2020
7455184
address review comments
medyagh Apr 3, 2020
4221e63
add logs for wait components
medyagh Apr 4, 2020
478d183
use all components list in should wait
medyagh Apr 4, 2020
77d1da0
change log level for err
medyagh Apr 4, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
reuse timeout
  • Loading branch information
@medyagh
medyagh committed Apr 3, 2020
commit fa9d47ae18e46ea11b191ebce262966f3a7567de
6 changes: 1 addition & 5 deletions pkg/minikube/bootstrapper/bsutil/kverify/default_sa.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,10 +33,6 @@ func WaitForDefaultSA(cs *kubernetes.Clientset, timeout time.Duration) error {
glog.Info("waiting for default service account to be created ...")
start := time.Now()
saReady := func() error {
if time.Since(start) > timeout {
glog.Error("exceeded max time to wait to verify cluster during waiting for default service account. will skip waiting.")
return nil
}
// equivalent to manual check of 'kubectl --context profile get serviceaccount default'
sas, err := cs.CoreV1().ServiceAccounts("default").List(meta.ListOptions{})
if err != nil {
Expand All @@ -51,7 +47,7 @@ func WaitForDefaultSA(cs *kubernetes.Clientset, timeout time.Duration) error {
}
return fmt.Errorf("couldn't find default service account")
}
if err := retry.Expo(saReady, 500*time.Millisecond, 120*time.Second); err != nil {
if err := retry.Expo(saReady, 500*time.Millisecond, timeout); err != nil {
return errors.Wrapf(err, "waited %s for SA", time.Since(start))
}

Expand Down