Merge pull request #7898 from medyagh/svc_url_wait

docker/podman drivers: wait for service before open url
kubernetes · Apr 25, 2020 · 947dc21 · 947dc21
2 parents e3a3b1e + 556e887
commit 947dc21
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/cmd/minikube/cmd/service.go b/cmd/minikube/cmd/service.go
@@ -80,11 +80,6 @@ var serviceCmd = &cobra.Command{
 		cname := ClusterFlagValue()
 		co := mustload.Healthy(cname)
 
-		if driver.NeedsPortForward(co.Config.Driver) {
-			startKicServiceTunnel(svc, cname)
-			return
-		}
-
 		urls, err := service.WaitForService(co.API, co.Config.Name, namespace, svc, serviceURLTemplate, serviceURLMode, https, wait, interval)
 		if err != nil {
 			var s *service.SVCNotFoundError
@@ -95,6 +90,11 @@ You may select another namespace by using 'minikube service {{.service}} -n <nam
 			exit.WithError("Error opening service", err)
 		}
 
+		if driver.NeedsPortForward(co.Config.Driver) {
+			startKicServiceTunnel(svc, cname)
+			return
+		}
+
 		openURLs(svc, urls)
 	},
 }