-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove pkg/config/config_test.json #9829
Conversation
GCE e2e build/test passed for commit 52d3cef5bfe00d9c92041f6e148ed5676eeab68e. |
Why are you removing this rather than replacing it with a v1 test? config.go and config_test.go still exist. |
I removed it because it's not used anywhere. Digging a little bit more, I found it was used to illustrate the format expected by "createall" (see here). I think we don't support the "createall" command anymore, so we can safely remove it. |
I don't see any obvious uses of this package. Can all of pkg/config be removed? |
It passes unit tests and integration tests after pkg/config is removed. I will remove the package in this PR. |
52d3cef
to
4799ba9
Compare
GCE e2e build/test passed for commit 4799ba9cbff6d30fae1624db989006542c68f4f6. |
I've removed pkg/config |
Needs a rebase |
4799ba9
to
5371d82
Compare
Rebased. Thanks. |
LGTM, thanks! |
GCE e2e build/test passed for commit 5371d82. |
remove pkg/config/config_test.json
#8087
@nikhiljindal @bgrant0607 @krousey