Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove pkg/config/config_test.json #9829

Merged
merged 1 commit into from
Jun 17, 2015

Conversation

caesarxuchao
Copy link
Member

@k8s-bot
Copy link

k8s-bot commented Jun 15, 2015

GCE e2e build/test passed for commit 52d3cef5bfe00d9c92041f6e148ed5676eeab68e.

@bgrant0607
Copy link
Member

Why are you removing this rather than replacing it with a v1 test?

config.go and config_test.go still exist.

@caesarxuchao
Copy link
Member Author

I removed it because it's not used anywhere. Digging a little bit more, I found it was used to illustrate the format expected by "createall" (see here). I think we don't support the "createall" command anymore, so we can safely remove it.

@bgrant0607
Copy link
Member

I don't see any obvious uses of this package. Can all of pkg/config be removed?

@caesarxuchao
Copy link
Member Author

It passes unit tests and integration tests after pkg/config is removed. I will remove the package in this PR.

@k8s-bot
Copy link

k8s-bot commented Jun 16, 2015

GCE e2e build/test passed for commit 4799ba9cbff6d30fae1624db989006542c68f4f6.

@caesarxuchao
Copy link
Member Author

I've removed pkg/config

@nikhiljindal
Copy link
Contributor

Needs a rebase

@caesarxuchao
Copy link
Member Author

Rebased. Thanks.

@nikhiljindal
Copy link
Contributor

LGTM, thanks!

@nikhiljindal nikhiljindal added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2015
@k8s-bot
Copy link

k8s-bot commented Jun 16, 2015

GCE e2e build/test passed for commit 5371d82.

saad-ali added a commit that referenced this pull request Jun 17, 2015
@saad-ali saad-ali merged commit fa389a6 into kubernetes:master Jun 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm "Looks good to me", indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants