Autoscaler implementation #9612

ramr · 2015-06-10T21:24:41Z

This is step 2 of the autoscaler implementation - building on the types defined by @pweil- in #5492
and the original autoscaler proposal from @smarterclayton at: #2863

To test, define a replication controller and an autoscaler configuration - example at: https://github.com/ramr/autoscaler-k8s-test/blob/master/test-as.json
and the replication controller gets scaled automatically to the min/max limits set in the autoscaler spec.

Or you can use the test repo at https://github.com/ramr/autoscaler-k8s-test

git clone https://github.com/ramr/autoscaler-k8s-test  
cd autoscaler-k8s-test  
make K8S_SOURCE_DIR=~/work/kubernetes test

and the replicas for the sample replication controller cluster/kubectl.sh get rc, should scale upto a limit of 6 replicas.

PTAL - Any comments/feedback greatly appreciated. Thx

googlebot · 2015-06-10T21:24:43Z

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please let us know the company's name.

k8s-bot · 2015-06-10T21:25:04Z

Can one of the admins verify that this patch is reasonable to test? (reply "ok to test", or if you trust the user, reply "add to whitelist")

If this message is too spammy, please complain to ixdy.

ramr · 2015-06-10T21:27:41Z

Signed the CLA.

googlebot · 2015-06-10T21:27:42Z

We found a Contributor License Agreement for you (the sender of this pull request) and all commit authors, but as best as we can tell these commits were authored by someone else. If that's the case, please add them to this pull request and have them confirm that they're okay with these commits being contributed to Google. If we're mistaken and you did author these commits, just reply here to confirm.

ramr · 2015-06-10T21:30:04Z

@pweil- Think the bot requires you to agree as well - since I used the original types from the unmerged PR - #5492

pweil- · 2015-06-10T21:31:02Z

Confirmed. I am @pweil- and I endorse this PR (politician smile)

ramr · 2015-06-16T19:47:27Z

(bump) + any way to check the failing builds?
Shippable says The build you're looking for wasn't found..

@smarterclayton FYI

smarterclayton · 2015-06-16T19:48:47Z

ok to test

smarterclayton · 2015-06-16T19:49:23Z

 ./hack/verify-description.sh
API file is missing the required field descriptions: ./pkg/api/v1beta3/types.go
API file is missing the required field descriptions: ./pkg/api/v1/types.go

k8s-bot · 2015-06-16T20:04:33Z

GCE e2e build/test passed for commit f726fc64c6ec57a81490315b6d44523885ecae7a.

k8s-bot · 2015-06-16T22:00:08Z

GCE e2e build/test passed for commit 5813ceb013c61f987bd97b071168e8c972d05535.

ramr · 2015-06-17T02:38:05Z

🆘 can't see the Shippable errors The build you're looking for wasn't found.?
Would be nice to know what tests the shippable stuff is running ...

smarterclayton · 2015-06-17T03:14:38Z

See the shippable yaml file

On Jun 16, 2015, at 10:38 PM, ramr notifications@github.com wrote:

can't see the Shippable errors The build you're looking for wasn't found.?
Would be nice to know what tests the shippable stuff is running ...

—
Reply to this email directly or view it on GitHub.

k8s-bot · 2015-06-17T20:16:43Z

GCE e2e build/test failed for commit 12d8f16186cef9fa26ef8cf0584d479dbfdd0c0a.

k8s-bot · 2015-06-17T20:16:45Z

GCE e2e build/test passed for commit c79a4cfaa1fff97ac9add2bb1a1e653d9c1cfe07.

ramr · 2015-06-17T20:52:02Z

k - third time's a charm!! PTAL - thx.

davidopp · 2015-06-22T05:52:04Z

pkg/api/v1/types.go

+// AutoScaleThreshold is a behavior based on statistics used to drive the auto-scaler in scaling decisions.
+type AutoScaleThreshold struct {
+	// Type is the type of threshold being used, intention or value.
+	Type AutoScaleThresholdType `json:"type,omitempty" description:"auto-scale threshold type; intention or value based"`


it wasn't clear to me how value-based works; intention-based is configured in Intentions field, but where is value-based configured?

Good question - don't think it was anywhere but am not sure if I have the right answer to that.

The types were as defined in the original autoscaler types PR ttps://github.com//pull/5492, and when I started to use them, found a couple of missing configuration pieces to evaluate the thresholds - the value and duration in particular, which I added to the AutoScaleIntentionThresholdConfig struct. Given what the intention thresholds support now, the value based thresholds could simply be folded into the intention based ones (aka just need the intention based thresholds - value based becomes a subset).

Don't know the history/discussions leading to the initial autoscaler types PR, so maybe @pweil- or @smarterclayton can shed more light on that. @pweil- / @smarterclayton ?

As the discussion progressed intention based threshold were the way everyone was leaning. I eventually removed the value based thresholds from the code (#5492 (comment)). The type is probably unnecessary at this point unless we intend to add value-based configs.

k8s-bot · 2015-06-30T22:11:20Z

GCE e2e build/test failed for commit 988bda5333c3d3d3616d05ce1558cc0d67e0e7fa.

ramr · 2015-06-30T23:19:57Z

Ok - this has been around for a while, so had to do some babysitting - rebased this to the latest code.

Can't see the build errors - only see a Build cannot be found error on shippable.

Any comments on what else is needed here + can you please let me know the shippable errors.
I can address the errors + comment re: autoscale threshold type that @davidopp had along w/ anything else that needs to be done here. Thanks.

k8s-bot · 2015-06-30T23:21:44Z

GCE e2e build/test passed for commit beb8d3414eb907ea2bf64332aea16780a9490f69.

davidopp · 2015-07-04T06:29:32Z

Unfortunately I don't think we're going to be able to give this attention until 1.0.

smarterclayton · 2015-07-04T18:07:15Z

@pmorie and I will do the bulk of the review for this, but we probably want
whomever has been involved in autoscaling on the Google side to take a look
as well.

On Jul 4, 2015, at 2:29 AM, David Oppenheimer notifications@github.com
wrote:

Unfortunately I don't think we're going to be able to give this attention
until 1.0.

—
Reply to this email directly or view it on GitHub
#9612 (comment)
.

k8s-bot · 2015-07-10T00:25:42Z

GCE e2e build/test passed for commit b4002170e34681968d829fc8bdf54887df480a5a.

k8s-bot · 2015-07-10T01:02:59Z

GCE e2e build/test passed for commit b4f91be18b033cd19961a6dc253e6afbfc678dd9.

bgrant0607 · 2015-07-28T11:07:49Z

cc @davidopp

smarterclayton · 2015-07-28T15:22:48Z

As discussed offline, if there are others who are interested in picking up
the autoscaler implementation and run with it for 1.1 we'd be happy to
assist or hand that off.

On Tue, Jul 28, 2015 at 7:08 AM, Brian Grant notifications@github.com
wrote:

cc @davidopp https://github.com/davidopp

—
Reply to this email directly or view it on GitHub
#9612 (comment)
.

Clayton Coleman | Lead Engineer, OpenShift

…l of Enabled field

* cleanup after code rebase: * add PrepareForCreate method to node and namespace strategies * fixes for updates to method signatures * remove unused imports * add the generated conversion functions for the autoscaler types * use new rest.StandardStorage for the registry storage * test fixes and added new tests * add duration and scale by fields * add autoscaler interfaces and default generic implementation * add scale reconciler * add autoscaler monitoring sources support * add autoscaler client methods + fake client support

@pweil-

* Refactor manager * Convert to using a work queue * Hook into kubernetes and controller manager code * Reorganize plugins * Copyright * Remove deprecated api code for merge/rebase w/ @pweil- changes * Some cleanup and renames * Remove merged labels * More refactoring * Add autoscaler registry pieces * Setup autoscale manager * Add and fix tests * Optimize policy assessment if there's no targets to operate on. * Add info log messages.

add a new strategy for updating autoscaler status.

…hods.

interface, regenerate docs and swagger spec and fixup tests for new storage interface.

k8s-bot · 2015-08-03T23:20:05Z

GCE e2e build/test passed for commit aba2814.

jszczepkowski · 2015-08-04T07:47:34Z

The updated design of simplified pod autoscaler is described in #12087 (all the discussion should take place there). We are planning to implement it as a part of 1.1.

ramr · 2015-08-05T18:32:57Z

@jszczepkowski yeah saw that afterwards. Rebased as it was outdated - was on the wait queue for a while now (almost a couple of months). Anyway that's a moot point now ...

@davidopp want me to close this out?

ncdc · 2015-08-25T17:13:12Z

This is superseded by 12087, right?

@jszczepkowski @ramr

ramr · 2015-08-25T22:29:10Z

@ncdc yes that is correct - finishing up the paperwork here.
Closing in favor of #12087

googlebot added the cla: no label Jun 10, 2015

davidopp self-assigned this Jun 10, 2015

davidopp reviewed Jun 22, 2015
View reviewed changes

ramr force-pushed the autoscaler branch from c79a4cf to 988bda5 Compare June 30, 2015 21:55

ramr force-pushed the autoscaler branch from beb8d34 to b400217 Compare July 9, 2015 23:45

ramr changed the title ~~[DO NOT MERGE] Autoscaler implementation~~ Autoscaler implementation Jul 10, 2015

piosz added the sig/autoscaling Categorizes an issue or PR as relevant to SIG Autoscaling. label Jul 20, 2015

davidopp mentioned this pull request Jul 31, 2015

Horizontal pod autoscaler basing on scale subresource #12087

Closed

pweil- and others added 14 commits August 3, 2015 19:27

auto-scaler types

315ee8b

updates based on feedback for types, comments, etcd factoring, remova…

db31b8f

…l of Enabled field

Change validation routine parameters to new,old form for clarity +

7904c26

add a new strategy for updating autoscaler status.

Add autoscalers alias and add autoscalers alias to "all".

59b2245

Add missing description fields for the autoscaler types.

7bb1b82

Add files modified by hack/run-gendocs.sh

309ca53

Add files generated by hack/update-swagger-spec.sh

694457c

Rebase code and add fixes for changed code due to rebase.

d5ab0e0

Add changed generated swagger spec.

de654f2

Due to rebase, add new parameter [wide] to the autoscaler printer met…

cb51e11

…hods.

Fix rebase newline gofmt error + add generated swagger spec files.

70d7077

Rebase PR for recent changes - move from using helper to the new storage

aba2814

interface, regenerate docs and swagger spec and fixup tests for new storage interface.

ramr force-pushed the autoscaler branch from b4f91be to aba2814 Compare August 3, 2015 22:46

ramr closed this Aug 25, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Autoscaler implementation #9612

Autoscaler implementation #9612

ramr commented Jun 10, 2015

googlebot commented Jun 10, 2015

k8s-bot commented Jun 10, 2015

ramr commented Jun 10, 2015

googlebot commented Jun 10, 2015

ramr commented Jun 10, 2015

pweil- commented Jun 10, 2015

ramr commented Jun 16, 2015

smarterclayton commented Jun 16, 2015

smarterclayton commented Jun 16, 2015

k8s-bot commented Jun 16, 2015

k8s-bot commented Jun 16, 2015

ramr commented Jun 17, 2015

smarterclayton commented Jun 17, 2015

k8s-bot commented Jun 17, 2015

k8s-bot commented Jun 17, 2015

ramr commented Jun 17, 2015

davidopp Jun 22, 2015

ramr Jun 22, 2015

pweil- Jun 22, 2015

k8s-bot commented Jun 30, 2015

ramr commented Jun 30, 2015

k8s-bot commented Jun 30, 2015

davidopp commented Jul 4, 2015

smarterclayton commented Jul 4, 2015

k8s-bot commented Jul 10, 2015

k8s-bot commented Jul 10, 2015

bgrant0607 commented Jul 28, 2015

smarterclayton commented Jul 28, 2015

k8s-bot commented Aug 3, 2015

jszczepkowski commented Aug 4, 2015

ramr commented Aug 5, 2015

ncdc commented Aug 25, 2015

ramr commented Aug 25, 2015

Autoscaler implementation #9612

Autoscaler implementation #9612

Conversation

ramr commented Jun 10, 2015

googlebot commented Jun 10, 2015

k8s-bot commented Jun 10, 2015

ramr commented Jun 10, 2015

googlebot commented Jun 10, 2015

ramr commented Jun 10, 2015

pweil- commented Jun 10, 2015

ramr commented Jun 16, 2015

smarterclayton commented Jun 16, 2015

smarterclayton commented Jun 16, 2015

k8s-bot commented Jun 16, 2015

k8s-bot commented Jun 16, 2015

ramr commented Jun 17, 2015

smarterclayton commented Jun 17, 2015

k8s-bot commented Jun 17, 2015

k8s-bot commented Jun 17, 2015

ramr commented Jun 17, 2015

davidopp Jun 22, 2015

Choose a reason for hiding this comment

ramr Jun 22, 2015

Choose a reason for hiding this comment

pweil- Jun 22, 2015

Choose a reason for hiding this comment

k8s-bot commented Jun 30, 2015

ramr commented Jun 30, 2015

k8s-bot commented Jun 30, 2015

davidopp commented Jul 4, 2015

smarterclayton commented Jul 4, 2015

k8s-bot commented Jul 10, 2015

k8s-bot commented Jul 10, 2015

bgrant0607 commented Jul 28, 2015

smarterclayton commented Jul 28, 2015

k8s-bot commented Aug 3, 2015

jszczepkowski commented Aug 4, 2015

ramr commented Aug 5, 2015

ncdc commented Aug 25, 2015

ramr commented Aug 25, 2015