Automated cherry pick of #92614: Don't create a new sandbox for pod with #94959
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
do-not-merge/cherry-pick-not-approved
k8s-ci-robot
added
size/L
k8s-ci-robot
added
area/kubelet
area/test
sig/node
… containers succeeded The kubelet would attempt to create a new sandbox for a pod whose RestartPolicy is OnFailure even after all container succeeded. It caused unnecessary CRI and CNI calls, confusing logs and conflicts between the routine that creates the new sandbox and the routine that kills the Pod. This patch checks the containers to start and stops creating sandbox if no container is supposed to start.
tnqn
force-pushed
the
automated-cherry-pick-of-#92614-upstream-release-1.18
branch
from
46482d7 to
d407bd5
Compare
|
/assign @dchen1107 @SergeyKanzhelev cc @alex-vmw |
|
from parent PR: /priority important-soon |
k8s-ci-robot
added
priority/important-soon
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
/assign @dchen1107 |
|
/lgtm |
k8s-ci-robot
added
the
approved
|
@SergeyKanzhelev @dashpole @dims Can you please approve/merge this for 1.18.11? |
|
/approve |
|
@puerco @gianarb @jimangel @markyjackson-taulia @mkorbi @onlydole @saschagrunert Could we please get a cherry-pick review and merge this into 1.18.11 now that it is approved? P.S. This is already merged into 1.19.4 as per #94725. |
cpanato
added
the
cherry-pick-approved
k8s-ci-robot
removed
the
do-not-merge/cherry-pick-not-approved
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato, dashpole, dchen1107, tnqn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry pick of #92614 on release-1.18.
#92614: Don't create a new sandbox for pod with
For details on the cherry pick process, see the cherry pick requests page.