Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[draft]remove hyper-v windows container support on docker #94531

Closed
wants to merge 1 commit into from
Closed

[draft]remove hyper-v windows container support on docker #94531

wants to merge 1 commit into from

Conversation

wawa0210
Copy link
Contributor

@wawa0210 wawa0210 commented Sep 4, 2020 •
edited
Loading

What type of PR is this?

What this PR does / why we need it:

Remove alpha support for Hyper-v on Docker for Windows

Which issue(s) this PR fixes:

Fixes #94490

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Remove alpha support for Hyper-v on Docker for Windows

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Remove alpha support for Hyper-v on Docker for Windows

/sig windows

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet sig/node Categorizes an issue or PR as relevant to SIG Node. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Sep 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wawa0210
To complete the pull request process, please assign dchen1107
You can assign the PR to them by writing /assign @dchen1107 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@wawa0210 wawa0210 force-pushed the remove-docker-hyperv-alpha-support branch from bfbd451 to 4ed815e Compare September 4, 2020 16:19
@wawa0210 wawa0210 changed the title remove hyper-v windows container support on docker [draft]remove hyper-v windows container support on docker Sep 4, 2020
@wawa0210
Copy link
Contributor Author

wawa0210 commented Sep 5, 2020

/test pull-kubernetes-e2e-azure-file-windows

@k8s-ci-robot
Copy link
Contributor

@wawa0210: The following test failed, say /retest to rerun all failed tests:

Test name Commit Details Rerun command
pull-kubernetes-e2e-azure-file-windows 4ed815e link /test pull-kubernetes-e2e-azure-file-windows

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

@wawa0210: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 13, 2020
@marosset marosset mentioned this pull request Oct 19, 2020
Closed
@spiffxp spiffxp added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Nov 5, 2020
@marosset
Copy link
Contributor

marosset commented Nov 5, 2020

/milestone v1.21

A log message saying this is deprecated has been added in v1.20.
We will remove in v1.21

@k8s-ci-robot k8s-ci-robot added this to the v1.21 milestone Nov 5, 2020
@wawa0210 wawa0210 closed this Dec 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees
No one assigned
Labels
area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.21
Development

Successfully merging this pull request may close these issues.

Remove alpha support for Hyper-v on Docker for Windows
4 participants
@wawa0210 @k8s-ci-robot @marosset @spiffxp