Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the winkernel proxy bug, when we try to delete a hnsendpoint which is still in use. #93465

Closed
wants to merge 1 commit into from
Closed

fix the winkernel proxy bug, when we try to delete a hnsendpoint which is still in use. #93465

wants to merge 1 commit into from

Conversation

xlgao-zju
Copy link
Contributor

@xlgao-zju xlgao-zju commented Jul 27, 2020 •
edited
Loading

What type of PR is this?
/kind bug

What this PR does / why we need it:
fix the winkernel proxy bug, when we try to delete a hnsendpoint which is still in use.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

fix the winkernel proxy bug, when we try to delete a hnsendpoint which is still in use.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jul 27, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xlgao-zju
To complete the pull request process, please assign feiskyer
You can assign the PR to them by writing /assign @feiskyer in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/network Categorizes an issue or PR as relevant to SIG Network. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 27, 2020
@xlgao-zju xlgao-zju force-pushed the fix-delete-hnsendpoint branch from c068a5d to 17066cf Compare July 27, 2020 07:11
@xlgao-zju
Copy link
Contributor Author

/assign @feiskyer

@xlgao-zju
Copy link
Contributor Author

/sig windows

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Jul 27, 2020
@xlgao-zju
Copy link
Contributor Author

/kind bug

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 27, 2020
@xlgao-zju xlgao-zju force-pushed the fix-delete-hnsendpoint branch from 17066cf to ec132f9 Compare July 27, 2020 08:31
fixed winkernel proxy deleting hnsendpoint being used.
27e7d34 
Signed-off-by: Xianglin Gao <xianglin.gxl@alibaba-inc.com>
@xlgao-zju xlgao-zju force-pushed the fix-delete-hnsendpoint branch from ec132f9 to 27e7d34 Compare July 27, 2020 08:38
@xlgao-zju
Copy link
Contributor Author

ping @dineshgovindasamy @madhanrm @feiskyer @ksubrmnn for review

@ksubrmnn
Copy link
Contributor

@kumarvin123 ptal

@xlgao-zju xlgao-zju changed the title fix the winkernel proxy bug, when we try to delete a hnsendpoint witch is still in use. fix the winkernel proxy bug, when we try to delete a hnsendpoint which is still in use. Jul 29, 2020
@ksubrmnn
Copy link
Contributor

ksubrmnn commented Aug 3, 2020

Thanks for the change @xlgao-zju!

Can you use this map with endpoint ref counts in your change? It should be more efficient https://github.com/kubernetes/kubernetes/blob/master/pkg/proxy/winkernel/proxier.go#L584

FYI @elweb9858 please continue to review

@ksubrmnn
Copy link
Contributor

ksubrmnn commented Aug 3, 2020

I believe this issue was fixed in #91706. I think this will be available in 1.19. Can you try building a binary with that change?

@elweb9858
Copy link
Contributor

Hi @xlgao-zju, thanks for looking into this issue! @sbangari is currently addressing this in #93638

@xlgao-zju
Copy link
Contributor Author

Hi @xlgao-zju, thanks for looking into this issue! @sbangari is currently addressing this in #93638

so, once #93638 is merged, we can close this issue.

@elweb9858
Copy link
Contributor

Hi @xlgao-zju, thanks for looking into this issue! @sbangari is currently addressing this in #93638

so, once #93638 is merged, we can close this issue.

I believe so. @sbangari can confirm.

@sbangari
Copy link
Contributor

sbangari commented Aug 6, 2020

Hi @xlgao-zju, thanks for looking into this issue! @sbangari is currently addressing this in #93638

so, once #93638 is merged, we can close this issue.

I believe so. @sbangari can confirm.

Yes #93638 will resolve this issue.

@feiskyer
Copy link
Member

feiskyer commented Aug 7, 2020

let's close this PR then.

/close

@k8s-ci-robot
Copy link
Contributor

@feiskyer: Closed this PR.

In response to this:

let's close this PR then.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@xlgao-zju xlgao-zju deleted the fix-delete-hnsendpoint branch August 7, 2020 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksubrmnn ksubrmnn Awaiting requested review from ksubrmnn

@madhanrm madhanrm Awaiting requested review from madhanrm

Assignees

@feiskyer feiskyer

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/network Categorizes an issue or PR as relevant to SIG Network. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@xlgao-zju @k8s-ci-robot @ksubrmnn @elweb9858 @sbangari @feiskyer