-
Notifications
You must be signed in to change notification settings - Fork 40k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add dockercfg to secret describer #9321
Conversation
Probably useful... https://golang.org/pkg/unicode/utf8/#Valid |
EXPERIMENTAL JENKINS PR BUILDER: e2e build succeeded. |
@pmorie same question. If you like it, I'll update this pull. |
I don't think we should print secret contents by default. |
does describe take flags? do we want another command to show secret content? |
Being able to see secret content is very useful when debugging the system. Things like "I made this secret, but my pod keeps telling me that it doesn't have access. Let me try that secret manually.". I'd like to have some way to see them. |
Fine with having a way to show it. But it should definitely take some extra effort to show it. |
and the raw |
|
sorry, bad button click:
Would you see that as an additional argument to describe ( |
I like that idea. |
Embarassing: I reviewed #7101 which added secret describers. Should have commented then. 😳 |
sorry |
GCE e2e build/test passed for commit a8a966e. |
Closing in favor of openshift/origin#3915 |
Adds dockercfg to the secret describer for prettier output.
@liggitt how would you feel about doing this sort of display by default if the length of the secret was less than 4k and we had some confidence it was text? There's got to be a library out there for codepage detection or some such.