Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dockercfg to secret describer #9321

Closed
wants to merge 1 commit into from

Conversation

deads2k
Copy link
Contributor

@deads2k deads2k commented Jun 5, 2015

Adds dockercfg to the secret describer for prettier output.

@liggitt how would you feel about doing this sort of display by default if the length of the secret was less than 4k and we had some confidence it was text? There's got to be a library out there for codepage detection or some such.

@liggitt
Copy link
Member

liggitt commented Jun 5, 2015

Probably useful... https://golang.org/pkg/unicode/utf8/#Valid

@k8s-bot
Copy link

k8s-bot commented Jun 5, 2015

EXPERIMENTAL JENKINS PR BUILDER: e2e build succeeded.

@deads2k
Copy link
Contributor Author

deads2k commented Jun 5, 2015

@pmorie same question. If you like it, I'll update this pull.

@erictune
Copy link
Member

erictune commented Jun 5, 2015

I don't think we should print secret contents by default.
People are going to send in kubectl describe output in bug reports, and they don't want to accidentally send in a secret.

@liggitt
Copy link
Member

liggitt commented Jun 5, 2015

does describe take flags? do we want another command to show secret content?

@deads2k
Copy link
Contributor Author

deads2k commented Jun 5, 2015

I don't think we should print secret contents by default.
People are going to send in kubectl describe output in bug reports, and they don't want to accidentally send in a secret.

Being able to see secret content is very useful when debugging the system. Things like "I made this secret, but my pod keeps telling me that it doesn't have access. Let me try that secret manually.". I'd like to have some way to see them.

@erictune
Copy link
Member

erictune commented Jun 5, 2015

Fine with having a way to show it. But it should definitely take some extra effort to show it.

@liggitt
Copy link
Member

liggitt commented Jun 5, 2015

and the raw get -o yaml is comically hard to use, since you have to extract the value and base64 decode it yoursefl

@deads2k
Copy link
Contributor Author

deads2k commented Jun 5, 2015

Fine with having a way to show it. But it should definitely take some extra effort to show it.

@deads2k deads2k closed this Jun 5, 2015
@deads2k deads2k reopened this Jun 5, 2015
@deads2k
Copy link
Contributor Author

deads2k commented Jun 5, 2015

sorry, bad button click:

Fine with having a way to show it. But it should definitely take some extra effort to show it.

Would you see that as an additional argument to describe (--show-confidential?), a separate command, or something else? I can't think of anything else we have that is confidential.

@pmorie
Copy link
Member

pmorie commented Jun 5, 2015

@deads2k

--show-confidential

I like that idea.

@erictune
Copy link
Member

erictune commented Jun 5, 2015

Embarassing: I reviewed #7101 which added secret describers. Should have commented then. 😳

@liggitt
Copy link
Member

liggitt commented Jun 5, 2015

sorry

@ghost ghost assigned erictune Jun 5, 2015
@k8s-bot
Copy link

k8s-bot commented Jun 11, 2015

GCE e2e build/test passed for commit a8a966e.

@erictune erictune added this to the v1.0-post milestone Jun 22, 2015
@bgrant0607 bgrant0607 removed this from the v1.0-post milestone Jul 24, 2015
@deads2k
Copy link
Contributor Author

deads2k commented Jul 27, 2015

Closing in favor of openshift/origin#3915

@deads2k deads2k closed this Jul 27, 2015
@deads2k deads2k deleted the dockercfg-describer branch July 31, 2015 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants