Allow kubectl proxy to proxy everything #9233
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… breaking the previous proxy behavior
|
EXPERIMENTAL JENKINS PR BUILDER: e2e build succeeded. |
|
Fixes #5921 |
|
lgtm. Aside from |
j3ffml
added
the
lgtm
|
I didn't try it but I'm pretty sure the UI would also have been affected, also any pprof stuff under /debug... |
|
cc/ @bprashanth |
ghost
pushed a commit
that referenced
this pull request
Jun 4, 2015
Allow kubectl proxy to proxy everything
ghost
merged commit 
|
@stephenR this change may affect your findings about proxy security. On Thu, Jun 4, 2015 at 4:22 PM, Quinton Hoole notifications@github.com
|
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current kubectl can't proxy anything that's not under the /api path. This removes that restriction while still allowing old tooling work the same.
This is required for kubectl to be a drop-in replacement for the RO port; prometheus example is updated to show this.