Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node pods e2e test: fix goroutine leak #91607

Closed
wants to merge 2 commits into from
Closed

node pods e2e test: fix goroutine leak #91607

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fef7ce9
node pods e2e test: fix leak
gaurav1086 May 31, 2020
ccf8ad7
call watch.Stop() for pending events
gaurav1086 Jul 11, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/e2e/node/pods.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,7 +272,7 @@ var _ = SIGDescribe("Pods Extended", func() {
// create the pod, capture the change events, then delete the pod
start := time.Now()
created := podClient.Create(pod)
ch := make(chan []watch.Event)
ch := make(chan []watch.Event, 1)
gaurav1086 marked this conversation as resolved.
Show resolved Hide resolved
gaurav1086 marked this conversation as resolved.
Show resolved Hide resolved
go func() {
defer close(ch)
w, err := podClient.Watch(context.TODO(), metav1.ListOptions{
Expand Down