Hi @gaurav1086. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: gaurav1086
To complete the pull request process, please assign yujuhong
You can assign the PR to them by writing /assign @yujuhong in a comment when ready.

The full list of commands accepted by this bot can be found here.

/assign @yujuhong

/ok-to-test

/retest

I don't get the point of this PR.
Are you facing actual issue like failing this test related to this change?

Even if not specifying the size of buffer, select works for both receiving and timeout as the following sample:

$ cat main.go 

package main

import "time"

func main() {
        var ch = make(chan int)

        go func() {
                time.Sleep(10 * time.Second)
                ch <- 10
        }()

        select {
        case val, ok := <-ch:
                if !ok {
                        print("ok is not true")
                }
                print("only got a single event: ", val)
        case <-time.After(5 * time.Second):
                print("timeout")
        }
}
$
$ go run main.go 
timeout

It is nice to submit the corresponding issue on github to share what you are trying to solve.

I don't get the point of this PR.
Are you facing actual issue like failing this test related to this change?

Even if not specifying the size of buffer, select works for both receiving and timeout as the following sample:

$ cat main.go 

package main

import "time"

func main() {
        var ch = make(chan int)

        go func() {
                time.Sleep(10 * time.Second)
                ch <- 10
        }()

        select {
        case val, ok := <-ch:
                if !ok {
                        print("ok is not true")
                }
                print("only got a single event: ", val)
        case <-time.After(5 * time.Second):
                print("timeout")
        }
}
$
$ go run main.go 
timeout

It is nice to submit the corresponding issue on github to share what you are trying to solve.

@oomichi add the sync.WaitGroup{} to expose this issue like this: https://play.golang.com/p/7zEa7TDXECh

@oomichi add the sync.WaitGroup{} to expose this issue like this: https://play.golang.com/p/7zEa7TDXECh

Thanks for the explanation. I got the point.
But in this file, the sync.WaitGroup() doesn't exist.
and wg.Wait() exists in the file but it seems for outside of this goroutine.

Again, could submit the corresponding issue on github to explain what issue you are facing actually?

@oomichi add the sync.WaitGroup{} to expose this issue like this: https://play.golang.com/p/7zEa7TDXECh

Thanks for the explanation. I got the point.
But in this file, the sync.WaitGroup() doesn't exist.
and wg.Wait() exists in the file but it seems for outside of this goroutine.

Again, could submit the corresponding issue on github to explain what issue you are facing actually?
@oomichi Here's a related issue: xref: #5316

@gaurav1086
The issue doesn't happen on current e2e test, right?

@gaurav1086
The issue doesn't happen on current e2e test, right?

@oomichi Not that I'm aware of since leaks are usually hard to catch.

cc @lavalamp @sttts

New changes are detected. LGTM label has been removed.

@gaurav1086: The following tests failed, say /retest to rerun all failed tests:

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@gaurav1086: PR needs rebase.

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@fejta-bot: Closed this PR.