Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote VolumeSubpathEnvExpansion e2e tests to Conformance #85128

Merged
merged 1 commit into from
Mar 23, 2020
Merged

Promote VolumeSubpathEnvExpansion e2e tests to Conformance #85128

merged 1 commit into from
Mar 23, 2020

Conversation

kevtaylor
Copy link
Contributor

@kevtaylor kevtaylor commented Nov 12, 2019 •
edited
Loading

What type of PR is this?
/kind api-change

What this PR does / why we need it:
VolumeSubpathEnvExpansion is GA in 1.17 so the e2e tests can be added to Conformance suite

Which issue(s) this PR fixes:
Fixes #85122

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

Please use the following format for linking documentation:
[KEP]: https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20181029-volume-subpath-env-expansion.md
[Usage]: kubernetes/website#13846
[Other doc]: kubernetes/enhancements#559

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 12, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @kevtaylor. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@kevtaylor
Copy link
Contributor Author

/sig testing
/sig node
/sig storage

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Nov 12, 2019
@kevtaylor
Copy link
Contributor Author

/cc @msau42

@k8s-ci-robot k8s-ci-robot requested a review from msau42 November 12, 2019 10:11
@fejta-bot
Copy link

This PR may require API review.

If so, when the changes are ready, complete the pre-review checklist and request an API review.

Status of requested reviews is tracked in the API Review project.

@msau42
Copy link
Member

msau42 commented Nov 13, 2019

/ok-to-test
/assign

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Nov 13, 2019
@kevtaylor
Copy link
Contributor Author

/retest

@kevtaylor kevtaylor force-pushed the kep/VolumeSubpathExpansion-Conformance branch from 0c66f2e to 3ed5ae9 Compare November 13, 2019 07:06
@k8s-ci-robot k8s-ci-robot added area/conformance Issues or PRs related to kubernetes conformance tests sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. labels Nov 13, 2019
@kevtaylor kevtaylor force-pushed the kep/VolumeSubpathExpansion-Conformance branch from 3ed5ae9 to 9252a94 Compare November 13, 2019 07:12
@kevtaylor
Copy link
Contributor Author

@msau42 I think that failing test is this #84940

@danielqsj danielqsj mentioned this pull request Nov 13, 2019
Merged
@kevtaylor
Copy link
Contributor Author

/retest

@kevtaylor
Copy link
Contributor Author

@johnbelamaric And the existing tests running in the grid are documented in the kep graduation criteria https://github.com/kubernetes/enhancements/blob/master/keps/sig-storage/20181029-volume-subpath-env-expansion.md#graduation-criteria

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 29, 2020
@kevtaylor kevtaylor force-pushed the kep/VolumeSubpathExpansion-Conformance branch from 1e501f8 to 2709039 Compare February 29, 2020 13:52
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Feb 29, 2020
@kevtaylor kevtaylor force-pushed the kep/VolumeSubpathExpansion-Conformance branch from 2709039 to dd308cc Compare February 29, 2020 13:54
@kevtaylor kevtaylor changed the title Promote VolumeSubpathExpansion e2e tests to Conformance Promote VolumeSubpathEnvExpansion e2e tests to Conformance Feb 29, 2020
@kevtaylor kevtaylor force-pushed the kep/VolumeSubpathExpansion-Conformance branch from dd308cc to dad426e Compare February 29, 2020 14:39
@kevtaylor
Copy link
Contributor Author

@johnbelamaric I saw that there is a new regime for conformance.txt which has been deleted. According to the new conformance instructions README the yaml file is at
cp bazel-genfiles/test/conformance/conformance.yaml test/conformance/testdata
but when I ran the bazel update it was in bazel-bin

Target //test/conformance:list_conformance_tests up-to-date:
  bazel-bin/test/conformance/conformance.yaml

Hopefully, that's the correct one

@kevtaylor
Copy link
Contributor Author

/retest

2 similar comments
@kevtaylor
Copy link
Contributor Author

/retest

@kevtaylor
Copy link
Contributor Author

/retest

@msau42
Copy link
Member

msau42 commented Mar 11, 2020

This lgtm, just have one comment to update the release since we missed the 1.19 window.
/approve

@kevtaylor kevtaylor force-pushed the kep/VolumeSubpathExpansion-Conformance branch from dad426e to 468b3b4 Compare March 12, 2020 20:06
@msau42
Copy link
Member

msau42 commented Mar 12, 2020

/lgtm
@johnbelamaric can you take another look?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 12, 2020
@kevtaylor
Copy link
Contributor Author

/retest

3 similar comments
@kevtaylor
Copy link
Contributor Author

/retest

@kevtaylor
Copy link
Contributor Author

/retest

@kevtaylor
Copy link
Contributor Author

/retest

@johnbelamaric
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: johnbelamaric, kevtaylor, msau42

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 23, 2020
@k8s-ci-robot k8s-ci-robot merged commit 1da4f75 into kubernetes:master Mar 23, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Mar 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@msau42 msau42 msau42 left review comments

@tallclair tallclair Awaiting requested review from tallclair

@yujuhong yujuhong Awaiting requested review from yujuhong

Assignees

@johnbelamaric johnbelamaric

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/conformance Issues or PRs related to kubernetes conformance tests area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/architecture Categorizes an issue or PR as relevant to SIG Architecture. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

Promote e2e tests for VolumeSubpathEnvExpansion to Conformance
5 participants
@kevtaylor @k8s-ci-robot @fejta-bot @msau42 @johnbelamaric