Adjust the cassandra example to use the service account. #8454
+51
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Part of #7444 |
|
@erictune too. |
| String serviceName = getEnvOrDefault("CASSANDRA_SERVICE", "cassandra"); | ||
| String path = "/api/v1beta3/namespaces/default/endpoints/"; | ||
| try { | ||
| String token = getServiceAccountToken(); | ||
|
|
||
| SSLContext ctx = SSLContext.getInstance("SSL"); |
There was a problem hiding this comment.
indentation is inconsistent...
There was a problem hiding this comment.
fixed. The perils of tab characters...
|
Comments addressed. ptal. |
| String hostPort = getEnvOrDefault("KUBERNETES_RO_SERVICE_PORT", "8080"); | ||
|
|
||
| String host = protocol + "://" + hostName + ":" + hostPort; | ||
| String host = "https://kubernetes.default.cluster.local"; | ||
| String serviceName = getEnvOrDefault("CASSANDRA_SERVICE", "cassandra"); | ||
| String path = "/api/v1beta3/namespaces/default/endpoints/"; |
There was a problem hiding this comment.
I'm gonna merge this, but maybe in a followup you can fix this to get the namespace from the downward API? This forces the example to work only in the default namespace unnecessarily.
|
LGTM |
lavalamp
added a commit
that referenced
this pull request
May 19, 2015
Adjust the cassandra example to use the service account.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@lavalamp