e2e: pass namespace when calling kubectl stop #8303
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This still suggests that at some point before #6194 |
|
Duplicate of #8309 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #7544, resources in the kubectl e2e test were being created in their own namespaces, but due to a bug introduced by #6194,
kubectl stopwas not failing, even though these resources did not exist in the default namespace, since the error was being ignored. This was not apparent until #8249 was merged, at which point it caused thekubectl stopcalls in cleanup to fail.This is now resolved by passing the namespace to kubectl in most of the test cases; in one case, I just removed the cleanup call entirely, as (I think) it's expected that one of the resources shouldn't exist, but I wasn't sure how best to handle that. Cleanup should still be handled adequately by the namespace being deleted, anyway.
Fixes #8300.