Updating some SkyDNS templates to v1beta3 #8273
Conversation
vishh
added
the
lgtm
| protocol: UDP | ||
| template: | ||
| metadata: | ||
| creationTimestamp: null |
There was a problem hiding this comment.
nit: Remove creationTimestamp here and in other places
|
Can we re-use the configs under |
|
I don't know if we can our not. I know these are used by util.sh in the same directory and passed through a rendering function. |
|
IIUC, the skydns configs under |
vmarmol
removed
the
lgtm
|
Please take another look as it was failing to build because some analytics links were missing from some README files. Is this ok? |
| - \"/etcd\" | ||
| - \"-bind-addr=127.0.0.1\" | ||
| - \"-peer-bind-addr=127.0.0.1\" | ||
| capabilities: {} |
There was a problem hiding this comment.
Please remove fields containing default values. The conversion script doesn't do that currently. If the field wasn't specified previously, it probably doesn't need to be specified in v1beta3, either, especially if it's just empty/false/0.
| - \"-bind-addr=127.0.0.1\" | ||
| - \"-peer-bind-addr=127.0.0.1\" | ||
| image: quay.io/coreos/etcd:latest | ||
| imagePullPolicy: Always |
There was a problem hiding this comment.
Why does this have pull policy Always? It didn't before.
There was a problem hiding this comment.
Defaults were added in the conversion and this is the default. Removing it.
|
Ping cc @lhuard1A |
| - \"/etcd\" | ||
| - \"-bind-addr=127.0.0.1\" | ||
| - \"-peer-bind-addr=127.0.0.1\" | ||
| image: quay.io/coreos/etcd:latest |
There was a problem hiding this comment.
In general, it's clearer to put name, then image, then other fields.
|
LGTM |
bgrant0607
added
the
lgtm
Updating some SkyDNS templates to v1beta3
#8087