Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kubectl config set hangs on some invalid property names #415 #79000

Merged
merged 1 commit into from
Jun 15, 2019
Merged

kubectl config set hangs on some invalid property names #415 #79000

merged 1 commit into from
Jun 15, 2019
+14 −0

Conversation

pswica
Copy link
Contributor

@pswica pswica commented Jun 13, 2019

What type of PR is this?
/kind bug
What this PR does / why we need it:
Fixes a bug where kubectl set config hangs and uses 100% CPU on some invalid property names
Which issue(s) this PR fixes:
Fixes kubernetes/kubectl#415
Special notes for your reviewer:
Does this PR introduce a user-facing change?:

Fixes a bug where `kubectl set config` hangs and uses 100% CPU on some invalid property names

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 13, 2019
@k8s-ci-robot
Copy link
Contributor

Hi @pswica. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@pswica
Copy link
Contributor Author

pswica commented Jun 13, 2019

/assign @adohe

@pswica
Copy link
Contributor Author

pswica commented Jun 13, 2019

/priority backlog

@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. priority/backlog Higher priority than priority/awaiting-more-evidence. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. labels Jun 13, 2019
@k8s-ci-robot k8s-ci-robot requested review from dshulyak and seans3 June 13, 2019 23:06
@liggitt
Copy link
Member

liggitt commented Jun 14, 2019

thanks for the PR. Can you add a test that would reproduce the error?

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 14, 2019
@pswica
Copy link
Contributor Author

pswica commented Jun 14, 2019

@liggitt
Thanks a lot for your feedback. I have added a test and changed the error message a bit.

@adohe-zz
Copy link

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jun 14, 2019
@adohe-zz
Copy link

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 14, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: adohe, pswica

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 14, 2019
@k8s-ci-robot k8s-ci-robot merged commit af9d54d into kubernetes:master Jun 15, 2019
@pswica pswica mentioned this pull request Jun 26, 2019
Closed
6 tasks
@liggitt liggitt mentioned this pull request Sep 5, 2019
Closed
@zhouya0 zhouya0 mentioned this pull request Jul 1, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshulyak dshulyak Awaiting requested review from dshulyak

@seans3 seans3 Awaiting requested review from seans3

Assignees

@adohe-zz adohe-zz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubectl cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. priority/backlog Higher priority than priority/awaiting-more-evidence. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubectl config set hangs on some invalid property names
4 participants
@pswica @k8s-ci-robot @liggitt @adohe-zz