Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate scheduler to use v1beta1 Event API #78447

Merged
merged 1 commit into from
Jul 12, 2019
Merged

Migrate scheduler to use v1beta1 Event API #78447

merged 1 commit into from
Jul 12, 2019

Conversation

yastij
Copy link
Member

@yastij yastij commented May 28, 2019

What type of PR is this?

/kind feature

What this PR does / why we need it: this migrate the scheduler to the v1beta1 Event API (and leaves the Lease to core)

Which issue(s) this PR fixes:

Special notes for your reviewer:

/assign @wojtek-t
/priority important-soon

Does this PR introduce a user-facing change?:

Migrate scheduler to use v1beta1 Event API. action required: any tool targeting scheduler events needs to use v1beta1 Event API

@k8s-ci-robot k8s-ci-robot added release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. kind/feature Categorizes issue or PR as related to a new feature. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 28, 2019
@yastij yastij changed the title Scheduler eventf Migrate scheduler to use v1beta1 Event API May 28, 2019
@k8s-ci-robot k8s-ci-robot added sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels May 28, 2019
@yastij
Copy link
Member Author

yastij commented May 28, 2019

FYI @bsalamat

@yastij yastij force-pushed the scheduler-eventf branch 4 times, most recently from 78e4a0b to f34adc5 Compare May 28, 2019 23:51
@yastij
Copy link
Member Author

yastij commented May 29, 2019

/test pull-kubernetes-bazel-test

@yastij yastij force-pushed the scheduler-eventf branch from f34adc5 to f269bac Compare May 29, 2019 02:38
@k8s-ci-robot k8s-ci-robot added area/test sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 29, 2019
@yastij yastij force-pushed the scheduler-eventf branch 4 times, most recently from 13daf1a to b4b43c0 Compare May 29, 2019 03:38
yastij
yastij commented May 29, 2019
View reviewed changes
Copy link
Member Author

@yastij yastij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wojtek-t - couple of items that needs your attention

staging/src/k8s.io/client-go/tools/events/interfaces.go Outdated Show resolved Hide resolved
test/integration/scheduler/util.go Outdated Show resolved Hide resolved
cmd/kube-scheduler/app/server.go Show resolved Hide resolved
@yastij yastij force-pushed the scheduler-eventf branch from b4b43c0 to fdca5f5 Compare May 29, 2019 03:51
@yastij
Copy link
Member Author

yastij commented May 29, 2019

@wojtek-t - first commit is from the event expansion PR. will be removed when rebasing on master

@yastij yastij force-pushed the scheduler-eventf branch from 440d0a0 to 97d8756 Compare July 11, 2019 08:49
@yastij yastij mentioned this pull request Jul 11, 2019
Merged
@yastij yastij force-pushed the scheduler-eventf branch from 97d8756 to 71c3fbe Compare July 11, 2019 18:35
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: k82cn, wojtek-t, yastij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@yastij
Copy link
Member Author

yastij commented Jul 11, 2019

/retest

wojtek-t
wojtek-t reviewed Jul 12, 2019
View reviewed changes
cmd/kube-scheduler/app/options/options.go Outdated Show resolved Hide resolved
cmd/kube-scheduler/app/server.go Show resolved Hide resolved
pkg/scheduler/scheduler.go Outdated Show resolved Hide resolved
pkg/scheduler/scheduler.go Outdated Show resolved Hide resolved
test/integration/util/util.go Show resolved Hide resolved
@yastij yastij force-pushed the scheduler-eventf branch 2 times, most recently from f3734dc to f92f590 Compare July 12, 2019 08:38
wojtek-t
wojtek-t reviewed Jul 12, 2019
View reviewed changes
Copy link
Member

@wojtek-t wojtek-t left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one last nit - other than that lgtm

pkg/scheduler/scheduler_test.go Outdated Show resolved Hide resolved
@yastij yastij force-pushed the scheduler-eventf branch from f92f590 to 142288e Compare July 12, 2019 08:46
@wojtek-t
Copy link
Member

/lgtm
/hold cancel

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. and removed do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. labels Jul 12, 2019
@yastij
move scheduler to use v1beta1.events
08522f8 
Signed-off-by: Yassine TIJANI <ytijani@vmware.com>
@yastij yastij force-pushed the scheduler-eventf branch from 142288e to 08522f8 Compare July 12, 2019 09:39
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2019
@wojtek-t
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 12, 2019
@k8s-ci-robot k8s-ci-robot merged commit b0d08f6 into kubernetes:master Jul 12, 2019
@wojtek-t wojtek-t mentioned this pull request Jul 16, 2019
Closed
@krzysied krzysied mentioned this pull request Jul 16, 2019
Closed
This was referenced Sep 19, 2019
Closed
Open
@yastij yastij mentioned this pull request Sep 26, 2019
Closed
@yastij yastij deleted the scheduler-eventf branch October 24, 2019 13:51
@cofyc cofyc mentioned this pull request Dec 18, 2019
Closed
This was referenced Apr 16, 2020
Merged
Merged
This was referenced Aug 25, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsalamat bsalamat bsalamat left review comments

@wojtek-t wojtek-t wojtek-t left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

@k82cn k82cn Awaiting requested review from k82cn

Assignees

@wojtek-t wojtek-t

@bsalamat bsalamat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-action-required Denotes a PR that introduces potentially breaking changes that require user action. sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/auth Categorizes an issue or PR as relevant to SIG Auth. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.16
Development

Successfully merging this pull request may close these issues.
9 participants
@yastij @k82cn @k8s-ci-robot @wojtek-t @fedebongio @fejta-bot @xmudrii @soggiest @bsalamat