Adding a script to update etcd objects as per the latest API Version #7819

nikhiljindal · 2015-05-05T23:57:26Z

Its a simple script that reads all objects and then writes them back as is to ensure that they are written using the latest API version.

cc @bgrant0607 @smarterclayton @lavalamp

lavalamp · 2015-05-06T00:09:53Z

hack/update-etcd-objects.sh

+    # Read and then write it back as is.
+    filename="/tmp/${resource}-${instance}.json"
+    ${KUBECTL} get ${resource} ${instance} -o json > $filename
+    ${KUBECTL} update -f $filename


do an update loop-- repeat the get/update if the update fails.

Done.
Added a loop of 5 retries.

bgrant0607 · 2015-05-06T18:38:32Z

hack/update-etcd-objects.sh

+    filename="/tmp/${resource}-${instance}.json"
+    ${KUBECTL} get ${resource} ${instance} -o json > $filename
+    ${KUBECTL} update -f $filename
+  done


Remove the tmp files.

bgrant0607 · 2015-05-06T18:42:40Z

hack/update-etcd-objects.sh

+    "pods"
+    "persistentvolumes"
+    "persistentvolumeclaims"
+    "rc"


replicationcontrollers

nikhiljindal · 2015-05-07T00:00:41Z

Thanks for all the comments.
Have updated the code accordingly.
Please have another look.

lavalamp · 2015-05-07T00:24:07Z

hack/update-etcd-objects.sh

+# TODO: Get this list of resources from server once
+# https://github.com/GoogleCloudPlatform/kubernetes/issues/2057 is fixed.
+declare -a resources=(
+#    "endpoints"


Are these commented out intentionally?

No sorry. Fixed

nikhiljindal · 2015-05-07T04:32:43Z

Updated the code as per comments.

lavalamp · 2015-05-07T17:44:31Z

I'm worried about testing-- can we copy/modify test-cmd.sh to make some v1beta1 objects, then restart apiserver, then run this script, then verify that the objects all got converted?

nikhiljindal · 2015-05-11T21:09:46Z

We need the following to add tests:

Ability to change the storage version.
Ability to change the latest version.
Ability to stop supporting v1beta1 api.

Will work on those as separate PRs and then come back and add a test here.

nikhiljindal · 2015-05-14T07:56:10Z

Have added hack/test-update-etcd-objects.sh to test the update script. It:

Starts a server that supports both the old and new api versions, with the old version being used for storage and creates a pod.
It then restarts the server to support both the old and new api versions, but this time, with the new version being used for storage. It then runs the update script against this server.
It then restarts the server to support only the new version. It then verifies that the server is still able to read the pod.
Verified that the test fails if step 2 is skipped.

Have made a few other changes to make the test work:

Have added a --runtime_config="api/all=false" flag to kube-apiserver, to disable all api versions. It is useful to enable just one specific api, for example by setting --runtime_config="api/all=false,api/v1beta3=true"
Have added an api/registered package to parse KUBE_API_VERSIONS env var and keep track of the api versions that should be registered. This is required since we want to know the list of versions to register before the APIs are registered. But latest requires the APIs to be registered before its init() is called. Hence, we cant figure out the list of versions to register in latest's init() as we are doing currently.
Another way to fix this was to make latest's init explicitly call each of the APIs to register themselves, but that seemed like a bigger change not fit for this PR. I can do that in next PR if required.

lavalamp · 2015-05-15T18:19:31Z

hack/test-cmd.sh

@@ -30,7 +30,6 @@ function cleanup()
    [[ -n ${APISERVER_PID-} ]] && kill ${APISERVER_PID} 1>&2 2>/dev/null
    [[ -n ${CTLRMGR_PID-} ]] && kill ${CTLRMGR_PID} 1>&2 2>/dev/null
    [[ -n ${KUBELET_PID-} ]] && kill ${KUBELET_PID} 1>&2 2>/dev/null
-    [[ -n ${PROXY_PID-} ]] && kill ${PROXY_PID} 1>&2 2>/dev/null


why this removal?

Doesnt seem to be used anywhere in this script.

lavalamp · 2015-05-15T18:22:15Z

hack/test-update-etcd-objects.sh

+UPDATE_ETCD_OBJECTS_SCRIPT="${KUBE_ROOT}/hack/update-etcd-objects.sh"
+
+function startApiServer() {
+kube::log::status "Starting kube-apiserver with KUBE_API_VERSIONS: ${KUBE_API_VERSIONS} and runtime_config: ${RUNTIME_CONFIG}"


indentation?

lavalamp · 2015-05-15T20:48:40Z

pkg/api/registered/registered.go

+limitations under the License.
+*/
+
+// Package to keep track of API Versions that have been registered in api.Scheme.


"should be registered"? This package doesn't actually do the registering, it just records intentions.

nikhiljindal · 2015-05-15T21:11:06Z

Updated the code as per comments.
Please have another look.

lavalamp · 2015-05-15T22:30:07Z

cmd/kube-apiserver/app/server.go

-		disableV1beta3 = true
+	// "api/all=false" allows users to selectively enable specific api versions.
+	disableAllAPIs := false
+	allAPIFlagValue, ok := s.RuntimeConfig["api/all"]


I had to go look this thing up. Is it documented anywhere? I would greatly prefer not having magic keys like "api/all" or "api/legacy"; I'd prefer an opt-out or opt-in list, and clarification (in the command line flag help message!) that it determines which api versions are served (as opposed to the other env var which determines which are understood).

I guess you didn't add api/legacy, so let's not touch that one. But can we avoid adding api/all?

Updated https://github.com/GoogleCloudPlatform/kubernetes/blob/master/docs/cluster_management.md#turn-on-or-off-an-api-version-for-your-cluster and also updated the help message for runtime_config flag.

lavalamp · 2015-05-15T22:31:32Z

Looking pretty good, I basically just have one last complaint.

lavalamp · 2015-05-15T23:24:14Z

LGTM

nikhiljindal · 2015-05-16T01:21:35Z

Shippable is green!

Adding a script to update etcd objects as per the latest API Version

googlebot added the cla: yes label May 5, 2015

nikhiljindal force-pushed the etcdTranslation branch from 935cd99 to 9c27979 Compare May 5, 2015 23:59

lavalamp reviewed May 6, 2015
View reviewed changes

mbforbes assigned lavalamp May 6, 2015

bgrant0607 reviewed May 6, 2015
View reviewed changes

bgrant0607 mentioned this pull request May 6, 2015

Return valid API paths for GET /api/<version> #2057

Closed

bgrant0607 reviewed May 6, 2015
View reviewed changes

nikhiljindal force-pushed the etcdTranslation branch from 9c27979 to 68229ae Compare May 6, 2015 23:57

nikhiljindal force-pushed the etcdTranslation branch from 68229ae to 7507e51 Compare May 7, 2015 00:02

lavalamp reviewed May 7, 2015
View reviewed changes

nikhiljindal force-pushed the etcdTranslation branch from 7507e51 to 5175c87 Compare May 7, 2015 04:31

nikhiljindal mentioned this pull request May 8, 2015

Adding an env variable to specify the list of supported API versions #7939

Merged

nikhiljindal mentioned this pull request May 12, 2015

Add a flag to disable legacy APIs #8083

Merged

nikhiljindal force-pushed the etcdTranslation branch 2 times, most recently from 8487d51 to 9481bcd Compare May 14, 2015 07:36

nikhiljindal force-pushed the etcdTranslation branch 2 times, most recently from 36d5cee to 3bd8819 Compare May 14, 2015 20:20

lavalamp reviewed May 15, 2015
View reviewed changes

nikhiljindal force-pushed the etcdTranslation branch from 3bd8819 to 9663281 Compare May 15, 2015 20:46

lavalamp reviewed May 15, 2015
View reviewed changes

nikhiljindal force-pushed the etcdTranslation branch from 9663281 to 1aae948 Compare May 15, 2015 21:09

nikhiljindal force-pushed the etcdTranslation branch from 1aae948 to c62875e Compare May 15, 2015 21:31

lavalamp reviewed May 15, 2015
View reviewed changes

nikhiljindal force-pushed the etcdTranslation branch from c62875e to a955c4a Compare May 15, 2015 23:18

Adding a script to update etcd objects

fa9f864

nikhiljindal force-pushed the etcdTranslation branch from a955c4a to fa9f864 Compare May 15, 2015 23:20

lavalamp added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2015

lavalamp added a commit that referenced this pull request May 16, 2015

Merge pull request #7819 from nikhiljindal/etcdTranslation

cf33705

Adding a script to update etcd objects as per the latest API Version

lavalamp merged commit cf33705 into kubernetes:master May 16, 2015

nikhiljindal unassigned lavalamp Aug 12, 2015

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Adding a script to update etcd objects as per the latest API Version #7819

Adding a script to update etcd objects as per the latest API Version #7819

nikhiljindal commented May 5, 2015

lavalamp May 6, 2015

nikhiljindal May 6, 2015

bgrant0607 May 6, 2015

nikhiljindal May 6, 2015

bgrant0607 May 6, 2015

nikhiljindal May 7, 2015

nikhiljindal commented May 7, 2015

lavalamp May 7, 2015

nikhiljindal May 7, 2015

nikhiljindal commented May 7, 2015

lavalamp commented May 7, 2015

nikhiljindal commented May 11, 2015

nikhiljindal commented May 14, 2015

lavalamp May 15, 2015

nikhiljindal May 15, 2015

lavalamp May 15, 2015

nikhiljindal May 15, 2015

lavalamp May 15, 2015

nikhiljindal May 15, 2015

nikhiljindal commented May 15, 2015

lavalamp May 15, 2015

nikhiljindal May 15, 2015

lavalamp commented May 15, 2015

lavalamp commented May 15, 2015

nikhiljindal commented May 16, 2015

Adding a script to update etcd objects as per the latest API Version #7819

Adding a script to update etcd objects as per the latest API Version #7819

Conversation

nikhiljindal commented May 5, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nikhiljindal commented May 7, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nikhiljindal commented May 7, 2015

lavalamp commented May 7, 2015

nikhiljindal commented May 11, 2015

nikhiljindal commented May 14, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nikhiljindal commented May 15, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

lavalamp commented May 15, 2015

lavalamp commented May 15, 2015

nikhiljindal commented May 16, 2015