Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

webhook admission tests: connect, proxy, binding, eviction #76910

Merged
merged 3 commits into from
Apr 23, 2019
Merged

webhook admission tests: connect, proxy, binding, eviction #76910

merged 3 commits into from
Apr 23, 2019

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Apr 22, 2019 •
edited
Loading

What type of PR is this?
/kind cleanup

What this PR does / why we need it:
Adds integration tests for webhook admission for:

  • pod connect subresources (exec, attach, portforward)
  • pod/service/node proxy subresources
  • pod binding/eviction subresources (and fixes validating admission calls for those requests)

Which issue(s) this PR fixes:
xref #76907
fixes #75193

Does this PR introduce a user-facing change?:

Validating admission webhooks are now properly called for CREATE operations on the following resources: pods/binding, pods/eviction, bindings

/cc @caesarxuchao @sbezverk

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 22, 2019
@k8s-ci-robot k8s-ci-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 22, 2019
@liggitt liggitt mentioned this pull request Apr 22, 2019
Closed
5 tasks
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Apr 22, 2019
@liggitt liggitt force-pushed the pod-admission branch 2 times, most recently from 4c36682 to a51ee34 Compare April 22, 2019 22:33
@liggitt liggitt added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Apr 22, 2019
@k8s-ci-robot k8s-ci-robot removed the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 22, 2019
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@liggitt liggitt changed the title Test webhook admission - pod connect subresources webhook admission tests: connect, proxy, binding, eviction Apr 23, 2019
@liggitt
Copy link
Member Author

liggitt commented Apr 23, 2019

/retest

This was referenced Apr 23, 2019
Closed
Closed
Closed
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed release-note-none Denotes a PR that doesn't merit a release note. labels Apr 23, 2019
@liggitt liggitt force-pushed the pod-admission branch 2 times, most recently from a13114a to aadc270 Compare April 23, 2019 14:21
@liggitt
Copy link
Member Author

liggitt commented Apr 23, 2019

/retest

@sbezverk
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 23, 2019
@liggitt
Copy link
Member Author

liggitt commented Apr 23, 2019

/retest

@k8s-ci-robot k8s-ci-robot merged commit 90fbbee into kubernetes:master Apr 23, 2019
@liggitt liggitt deleted the pod-admission branch April 23, 2019 19:16
@liggitt liggitt mentioned this pull request Apr 24, 2019
Merged
@rmohr rmohr mentioned this pull request Aug 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbezverk sbezverk sbezverk left review comments

@caesarxuchao caesarxuchao Awaiting requested review from caesarxuchao

Assignees

@sbezverk sbezverk

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/admission-control area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Intercepting the "pods/eviction" subresource via validating webhooks should work
3 participants
@liggitt @k8s-ci-robot @sbezverk