Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend PR#5470 for AWS and Vagrant #7112

Merged
merged 1 commit into from
Apr 22, 2015

Conversation

erictune
Copy link
Member

Creates "builtin service account" tokens at cluster startup.

@erictune
Copy link
Member Author

Anyone can review this since it is not cloud-provider specific.

FYI @justinsb for AWS change
FYI @derekwaynecarr for vagrant change

@justinsb
Copy link
Member

LGTM.

Any reason you didn't create a shared function in cluster/common.sh (like create-kubeconfig)?

@derekwaynecarr
Copy link
Member

Lgtm

@erictune
Copy link
Member Author

I wanted to call this from configure-vm.sh which cannot include other files because it is inlined into the instance metadata.

@zmerlynn it is annoying to not be able to call a library function from configure-vm.sh. Were you implying in your review comments in a PR that it might be possible to move auth-setup stuff out of configure-vm to a later step?

@zmerlynn
Copy link
Member

@erictune: You should be able to move it after the download-release phase, which gets you access to kubectl, at least (which was a problem you had before, no binaries at all). That doesn't get you access to cluster/common.sh, though.

When configure-vm.sh was hatched, there actually were no common bash libraries. :/

@erictune
Copy link
Member Author

@zmerlynn have you thought about how we will distribute known_tokens.csv to multiple masters once we have multi-master?

@erictune
Copy link
Member Author

Okay, I suggest that we merge this and I'll talk with @zmerlynn offline how to make this more consistent across AWS and Vagrant.

@zmerlynn
Copy link
Member

@erictune: Eventually, I'd like to get around to implementing phase 2 of #3579, which makes the add-on crap-script more of a controller in a pod. I wonder if we could manage the secrets containers using that controller, or if there's a chicken/egg issue somewhere? (I haven't had time to think about any of that, though.)

@fabioy
Copy link
Contributor

fabioy commented Apr 21, 2015

Would like to merge, but both Shippable and travis-ci show build failures. Could you investigate? Thank you.

@erictune
Copy link
Member Author

Go 1.4 passes travis. Go 1.3 failed integration test on travis, but must be a flake because this PR touches no go files, and could not interact with integration testing.

Checking Shippable requires giving permissions to Shippable that I won't give.

@zmerlynn
Copy link
Member

Shippable is an integration test flake, too. Merging.

zmerlynn added a commit that referenced this pull request Apr 22, 2015
Extend PR#5470 for AWS and Vagrant
@zmerlynn zmerlynn merged commit b98f93b into kubernetes:master Apr 22, 2015
@erictune erictune deleted the kubeconfig-secrets branch September 29, 2015 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants