Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate the update-demo to use v1beta3. #7019

Merged
merged 1 commit into from
Apr 20, 2015
Merged

Migrate the update-demo to use v1beta3. #7019

merged 1 commit into from
Apr 20, 2015

Conversation

roberthbailey
Copy link
Contributor

Small part of #6584.

@nikhiljindal
Copy link
Contributor

Thanks a lot @roberthbailey!
LGTM.

nikhiljindal added a commit that referenced this pull request Apr 20, 2015
@nikhiljindal
Merge pull request #7019 from roberthbailey/update-demo-v1beta3
f2c62c9 
Migrate the update-demo to use v1beta3.
@nikhiljindal nikhiljindal merged commit f2c62c9 into kubernetes:master Apr 20, 2015
@ixdy
Copy link
Member

ixdy commented Apr 20, 2015

I think this change broke examples/examples_test.go but was masked by #7052.

https://travis-ci.org/GoogleCloudPlatform/kubernetes/jobs/59004529:

--- FAIL: TestExampleObjectSchemas (0.23s)
    examples_test.go:207: Expected no error, Got lstat ../examples/update-demo/v1beta3: no such file or directory
    examples_test.go:210: Expected 2 examples, Got 0
    examples_test.go:207: Expected no error, Got lstat ../examples/update-demo/v1beta1: no such file or directory
    examples_test.go:210: Expected 2 examples, Got 0
FAIL
coverage: 0.0% of statements
FAIL    github.com/GoogleCloudPlatform/kubernetes/examples  0.436s

https://travis-ci.org/GoogleCloudPlatform/kubernetes/jobs/59004530:

--- FAIL: TestExampleObjectSchemas (0.34 seconds)
    examples_test.go:207: Expected no error, Got lstat ../examples/update-demo/v1beta1: no such file or directory
    examples_test.go:210: Expected 2 examples, Got 0
    examples_test.go:207: Expected no error, Got lstat ../examples/update-demo/v1beta3: no such file or directory
    examples_test.go:210: Expected 2 examples, Got 0
FAIL
coverage: 0.0% of statements
FAIL    github.com/GoogleCloudPlatform/kubernetes/examples  0.621s

@j3ffml
Copy link
Contributor

j3ffml commented Apr 20, 2015

Yeah, I'm currently testing one-line fix. Will send to @roberthbailey shortly.

@j3ffml j3ffml mentioned this pull request Apr 20, 2015
Closed
@roberthbailey
Copy link
Contributor Author

Ugh. I even ran e2e on this to make sure I did it correctly. :/

@yifan-gu yifan-gu mentioned this pull request Apr 20, 2015
Merged
@roberthbailey roberthbailey deleted the update-demo-v1beta3 branch April 21, 2015 03:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@nikhiljindal nikhiljindal

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@roberthbailey @nikhiljindal @ixdy @j3ffml @googlebot