Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manually cherry pick part of #58712: Add better event handling for deleted Pods #69931

Closed
wants to merge 1 commit into from
Closed

Manually cherry pick part of #58712: Add better event handling for deleted Pods #69931

wants to merge 1 commit into from

Conversation

jimmy-zh
Copy link
Contributor

@jimmy-zh jimmy-zh commented Oct 17, 2018 •
edited
Loading

What this PR does / why we need it:
Manually cherry pick part of #58712 on release-1.8.

#58712: This PR makes the event handling logic more robust by adding logic to check for cache.DeletedFinalStateUnknown in our event handler filters.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #69926

Special notes for your reviewer:
See #69926 for more details.

Release note:

Stability: Make Pod delete event handling of scheduler more robust.

/sig scheduling

@k8s-ci-robot k8s-ci-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Oct 17, 2018
@k8s-ci-robot
Copy link
Contributor

@jimmy-zh: This PR is not for the master branch but does not have the cherry-pick-approved label. Adding the do-not-merge/cherry-pick-not-approved label.

To approve the cherry-pick, please assign the patch release manager for the release branch by writing /assign @username in a comment when ready.

The list of patch release managers for each release can be found here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot
Copy link
Contributor

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. needs-kind Indicates a PR lacks a `kind/foo` label and requires one. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Oct 17, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jimmy-zh
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: k82cn

If they are not already assigned, you can assign the PR to them by writing /assign @k82cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. and removed needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Oct 17, 2018
bsalamat
bsalamat suggested changes Oct 17, 2018
View reviewed changes
Copy link
Member

@bsalamat bsalamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current released "patch" version of K8s is 1.12. Version 1.11 and 1.10 are still supported, but 1.9 and older are considered EOL. We do not backport fixes to those versions.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Oct 18, 2018
@idealhack
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@idealhack: Closing this PR.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@idealhack
Copy link
Member

It seems this is a fix worth merge?

/kind bug
/reopen
@kubernetes/sig-scheduling-bugs

@k8s-ci-robot
Copy link
Contributor

@idealhack: Reopening this PR.

In response to this:

It seems this is a fix worth merge?

/kind bug
/reopen
@kubernetes/sig-scheduling-bugs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added kind/bug Categorizes issue or PR as related to a bug. and removed needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Oct 18, 2018
@k8s-ci-robot k8s-ci-robot reopened this Oct 18, 2018
@idealhack
Copy link
Member

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Oct 18, 2018
@jimmy-zh
Copy link
Contributor Author

/retest

@k8s-ci-robot
Copy link
Contributor

@jimmy-zh: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-bazel-build eb76054 link /test pull-kubernetes-bazel-build
pull-kubernetes-bazel-test eb76054 link /test pull-kubernetes-bazel-test
pull-kubernetes-e2e-kops-aws eb76054 link /test pull-kubernetes-e2e-kops-aws
pull-kubernetes-e2e-gce eb76054 link /test pull-kubernetes-e2e-gce
pull-kubernetes-e2e-gce-device-plugin-gpu eb76054 link /test pull-kubernetes-e2e-gce-device-plugin-gpu
pull-kubernetes-kubemark-e2e-gce-big eb76054 link /test pull-kubernetes-kubemark-e2e-gce-big
pull-kubernetes-node-e2e eb76054 link /test pull-kubernetes-node-e2e
pull-kubernetes-typecheck eb76054 link /test pull-kubernetes-typecheck
pull-kubernetes-verify eb76054 link /test pull-kubernetes-verify
pull-kubernetes-integration eb76054 link /test pull-kubernetes-integration

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jimmy-zh
Copy link
Contributor Author

The problem we encountered has been described in detail in #69926. The scheduler of version 1.8 and 1.9 will eventually become unavailable without this fix. Many users, including our own customers, still rely on version 1.8 or 1.9, so this pr should be valuable.

@bsalamat
Copy link
Member

The problem we encountered has been described in detail in #69926. The scheduler of version 1.8 and 1.9 will eventually become unavailable without this fix. Many users, including our own customers, still rely on version 1.8 or 1.9, so this pr should be valuable.

I understand, but 1.8 and 1.9 are no longer built and released officially. So, even if you backport patches, no more dot versions will be built and released. I would strongly recommend upgrading your clusters.

@liggitt
Copy link
Member

liggitt commented Dec 6, 2018

/close

no additional 1.8 releases are planned

@k8s-ci-robot
Copy link
Contributor

@liggitt: Closed this PR.

In response to this:

/close

no additional 1.8 releases are planned

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsalamat bsalamat bsalamat requested changes

@jayunit100 jayunit100 Awaiting requested review from jayunit100

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jimmy-zh @k8s-ci-robot @idealhack @bsalamat @liggitt