Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

promote TaintBasedEvictions featuregate to beta #69824

Merged
merged 1 commit into from
Oct 18, 2018
Merged

promote TaintBasedEvictions featuregate to beta #69824

merged 1 commit into from
Oct 18, 2018

Conversation

Huang-Wei
Copy link
Member

@Huang-Wei Huang-Wei commented Oct 15, 2018 •
edited
Loading

What this PR does / why we need it:

Enable TaintBasedEvictions featuregate by default.

Which issue(s) this PR fixes:

Part of #69533.

Special notes for your reviewer:

Release note:

`TaintBasedEvictions` feature is promoted to beta.

/kind feature
/sig scheduling

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. kind/feature Categorizes issue or PR as related to a new feature. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 15, 2018
@Huang-Wei Huang-Wei mentioned this pull request Oct 15, 2018
Closed
7 tasks
@Huang-Wei
Copy link
Member Author

/test pull-kubernetes-integration

@Huang-Wei
Copy link
Member Author

Huang-Wei commented Oct 16, 2018 •
edited
Loading

/assign @k82cn @bsalamat

@k8s-ci-robot
Copy link
Contributor

@Huang-Wei: GitHub didn't allow me to assign the following users: for, approval.

Note that only kubernetes members and repo collaborators can be assigned.
For more information please see the contributor guide

In response to this:

/assign @k82cn @bsalamat for approval

/unassign @smarterclayton @dchen1107

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k82cn
Copy link
Member

k82cn commented Oct 16, 2018

/lgtm

The notes should be "Upgraded TaintBasedEvictions feature to beta" or something similar.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2018
@Huang-Wei
Copy link
Member Author

@k82cn sure.

@Huang-Wei
Copy link
Member Author

/cc @bsalamat

for approval.

@k8s-ci-robot k8s-ci-robot requested a review from bsalamat October 16, 2018 17:19
yastij
yastij approved these changes Oct 16, 2018
View reviewed changes
Copy link
Member

@yastij yastij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

bsalamat
bsalamat approved these changes Oct 16, 2018
View reviewed changes
Copy link
Member

@bsalamat bsalamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bsalamat, Huang-Wei

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2018
@spiffxp
Copy link
Member

spiffxp commented Oct 17, 2018

/hold
Shouldn't this be the last item to merge out of everything listed on #69533 ?

Feel free to /hold cancel if I'm wrong, but it just seems odd to move to beta and then bump test coverage. If we had test coverage gates in place we definitely wouldn't allow this?

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 17, 2018
@spiffxp spiffxp mentioned this pull request Oct 17, 2018
Closed
@Huang-Wei
Copy link
Member Author

@spiffxp in theory, you're right. But there are usually other aspects not being properly covered in unit test/integration test/e2e test. Like in previous release, we met some scalability issue in last moment of promoting TaintNodeByCondition to beta.

And even for e2e test, I don't have a gce/gke/aws env, so I only run it against my local kubeadm cluster. It'd be good to see how prow job works after the featuregate is enabled.

So based on above considerations, and our understanding/test coverage on this featuregate, at this moment we're confident to enable it in master branch.

@AishSundar
Copy link
Contributor

/milestone v1.13

@k8s-ci-robot k8s-ci-robot added this to the v1.13 milestone Oct 17, 2018
@Huang-Wei
Copy link
Member Author

Huang-Wei commented Oct 17, 2018 •
edited
Loading

@spiffxp I'd like do a hold cancel after merge of #65350 is completed.

@Huang-Wei
Copy link
Member Author

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Oct 18, 2018
@k8s-ci-robot k8s-ci-robot merged commit 7a53a07 into kubernetes:master Oct 18, 2018
@Huang-Wei Huang-Wei deleted the enable-TaintBasedEvictions branch October 18, 2018 05:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bsalamat bsalamat bsalamat approved these changes

@yastij yastij yastij approved these changes

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@smarterclayton smarterclayton Awaiting requested review from smarterclayton

Assignees

@yastij yastij

@bsalamat bsalamat

@k82cn k82cn

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.13
Development

Successfully merging this pull request may close these issues.
7 participants
@Huang-Wei @k8s-ci-robot @k82cn @spiffxp @AishSundar @yastij @bsalamat