Enable Kubelet profiling #6964
Closed
Enable Kubelet profiling #6964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also see #6952 @mikedanese |
|
I would prefer to have this pprof handler serving on http like the others do so I could run: I was not able to get go tool pprof to work with https. |
| @@ -80,7 +82,7 @@ func ListenAndServeKubeletServer(host HostInterface, address net.IP, port uint, | |||
| // ListenAndServeKubeletReadOnlyServer initializes a server to respond to HTTP network requests on the Kubelet. | |||
| func ListenAndServeKubeletReadOnlyServer(host HostInterface, address net.IP, port uint) { | |||
| glog.V(1).Infof("Starting to listen read-only on %s:%d", address, port) | |||
| s := &Server{host, http.NewServeMux()} | |||
| s := &Server{host, http.NewServeMux(), true} | |||
There was a problem hiding this comment.
Why does the Kubelet ReadOnly Server set profiling to always on?
|
I merged #6952 this morning, adding profiling to the kubelet's healthz port. I don't think that we should add it to the RO port, since we are working to remove the RO port. |
|
Closing in favor of #6952 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new command line flag to kubelet that enables
/debug/pprof/, similar to what has already been added to apiserver and controller-manager.xref d2iq-archive/kubernetes-mesos#155
cc @bgrant0607 @davidopp @alex-mohr