Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable profiling on kubelet healthz port #6952

Merged
merged 1 commit into from
Apr 17, 2015
Merged

Enable profiling on kubelet healthz port #6952

merged 1 commit into from
Apr 17, 2015
+1 −0

Conversation

mikedanese
Copy link
Member

This and scheduler are the last two kube-apps without an enable_profiling flag.

@roberthbailey
Copy link
Contributor

Profiling sounds great but I'm curious why you want it on the read-only port (which we are working to get rid of -- see #5921). @erictune

@mikedanese
Copy link
Member Author

I was not able to get go tool pprof https://... to work without something extra to terminate TLS. proxy, controllermanager, and apiserver register pprof handlers with the mux's serving http on 127.0.0.1. Kubelet currently listens on 3 ports. KubeletPort and KubeletReadOnlyPort listen on 0.0.0.0 and KubeletStatusPort listens on 127.0.0.1 by default. It would probably make sense to host this on the KubeletStatusPort.

@roberthbailey
Copy link
Contributor

I agree that we should add it to the status/healthz port (10248) instead of the RO port. The RO port was a (hopefully temporary) hack to get heapster working and I'd like to find a way to turn it off down the road.

@roberthbailey roberthbailey mentioned this pull request Apr 17, 2015
Closed
@mikedanese mikedanese force-pushed the kubelet-profiling branch 2 times, most recently from 8df521e to 7b13870 Compare April 17, 2015 06:20
@mikedanese mikedanese changed the title add enable_profiling option to kubelet ro port add enable_profiling option to kubelet healthz port Apr 17, 2015
@mikedanese
Copy link
Member Author

Done.

roberthbailey added a commit that referenced this pull request Apr 17, 2015
@roberthbailey
Merge pull request #6952 from mikedanese/kubelet-profiling
f3dd053 
add enable_profiling option to kubelet healthz port
@roberthbailey roberthbailey merged commit f3dd053 into kubernetes:master Apr 17, 2015
@mikedanese mikedanese deleted the kubelet-profiling branch April 17, 2015 15:11
@mikedanese mikedanese changed the title add enable_profiling option to kubelet healthz port Enable profiling on kubelet healthz port Apr 17, 2015
@roberthbailey roberthbailey self-assigned this Apr 17, 2015
@guenter guenter mentioned this pull request Apr 17, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@roberthbailey roberthbailey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mikedanese @roberthbailey @googlebot