Add an integration test that checks for the metrics we expect to be exported from the master #6941
Conversation
| t.Fatalf("unexpected error: %v", err) | ||
| } | ||
|
|
||
| var m *master.Master |
There was a problem hiding this comment.
I know you just moved this code, but there's no reason to do it in this order. Create the master first, then create the http server.
| // Make a request to the apiserver to ensure there's at least one data point | ||
| // for the metrics we're expecting -- otherwise, they won't be exported. | ||
| client := client.NewOrDie(&client.Config{Host: s.URL, Version: testapi.Version()}) | ||
| _, err := client.Pods(api.NamespaceDefault).List(labels.Everything()) |
There was a problem hiding this comment.
if _, err := ...; err != nil
…xported from the master.
|
Fixed up all comments except the one I responded to about passing testing.T around. |
|
LGTM. Will merge on green. |
roberthbailey
added
the
lgtm
Add an integration test that checks for the metrics we expect to be exported from the master
|
This is broken on the Mac (cadvisor is disabled due to compile) - going to open a pull to skip this when cadvisor is not real. |
|
Oops, I mean, because prometheus does not not support procfs on macs |
|
Sorry, I didn't consider that. SGTM, although I wonder how it made it this long if it's been failing on macs since it was merged. |
|
Most people probably aren't running integration :) |
|
Integration tests were already failing on macs (see #7282) so no one would have noticed this. |
Fixes #6887.