Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

KubeletPluginsWatcher feature is beta in 1.12 release #68200

Merged
merged 4 commits into from
Sep 5, 2018
Merged

KubeletPluginsWatcher feature is beta in 1.12 release #68200

merged 4 commits into from
Sep 5, 2018

Conversation

RenaudWasTaken
Copy link
Contributor

What this PR does / why we need it:
Graduates DevicePlugins feature to beta.

Which issue(s) this PR fixes:
Related but does not fix: kubernetes/enhancements#595 as well as #65773

Special notes for your reviewer:
Includes upgrading the gRPC pluginwatcher API to beta. Based on the device plugin model.

Depends on #64621 being merged

Release note:

KubeletPluginsWatcher feature graduates to beta.

/sig node
/sig storage

/cc @vladimirvivien @sbezverk @vikaschoudhary16 @saad-ali @vishh @jiayingz

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Sep 3, 2018
@k8s-ci-robot k8s-ci-robot added sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/kubelet labels Sep 3, 2018
@saad-ali
Copy link
Member

saad-ali commented Sep 3, 2018

/milestone 1.12

@k8s-ci-robot
Copy link
Contributor

@saad-ali: The provided milestone is not valid for this repository. Milestones in this repository: [next-candidate, v1.10, v1.11, v1.12, v1.13, v1.4, v1.5, v1.6, v1.7, v1.8, v1.9]

Use /milestone clear to clear the milestone.

In response to this:

/milestone 1.12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@saad-ali
Copy link
Member

saad-ali commented Sep 3, 2018

/milestone v1.12

@k8s-ci-robot k8s-ci-robot added this to the v1.12 milestone Sep 3, 2018
saad-ali
saad-ali approved these changes Sep 3, 2018
View reviewed changes
Copy link
Member

@saad-ali saad-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 3, 2018
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 4, 2018
@RenaudWasTaken
Copy link
Contributor Author

Updated hack/.golint_failures to ignore the lint failures of the generated gRPC file

@RenaudWasTaken
Copy link
Contributor Author

/retest

vishh
vishh reviewed Sep 4, 2018
View reviewed changes
Copy link
Contributor

@vishh vishh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you summarize the level of test coverage that we have for this feature?
How confident are we with the API?

pkg/kubelet/apis/pluginregistration/v1beta1/api.proto Outdated
// This allows the plugin to register using one endpoint and possibly use
// a different socket for control operations. CSI uses this model to delegate
// its registration external from the plugin.
string endpoint = 3;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Fix indentation.

@RenaudWasTaken
Copy link
Contributor Author

RenaudWasTaken commented Sep 4, 2018 •
edited
Loading

PR updated to fix the indentation.

@vishh

Can you summarize the level of test coverage that we have for this feature?
How confident are we with the API?

  • 80.6% go test coverage
  • We have a few unit test coverage of this feature on the device plugin side
  • I believe we have e2e node test coverage of this feature
  • We have an in flight PR on the device plugin side for e2e tests
  • E2E tests for the CSI side will probably be in the next cycle

This is also the feature that CSI uses for it's plugins.

IMHO I'm confident the API won't need to be changed.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 4, 2018
@saad-ali
Copy link
Member

saad-ali commented Sep 5, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2018
@verult
Copy link
Contributor

verult commented Sep 5, 2018

@RenaudWasTaken the CSI test failure is likely due to missing driver-registrar params, so CSI driver isn't getting registered by the kubelet registration mechanism. Try this:
verult@666eff4

@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@liggitt liggitt mentioned this pull request Sep 5, 2018
Merged
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-ci-robot k8s-ci-robot added sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed lgtm "Looks good to me", indicates that a PR is ready to be merged. labels Sep 5, 2018
@RenaudWasTaken
Copy link
Contributor Author

@verult thanks! I added pulled your patch on top

@RenaudWasTaken
Copy link
Contributor Author

/retest

@vladimirvivien
Copy link
Member

/lgtm

@vladimirvivien
Copy link
Member

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Sep 5, 2018
vladimirvivien
vladimirvivien reviewed Sep 5, 2018
View reviewed changes
Copy link
Member

@vladimirvivien vladimirvivien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I lgtm'd it

@childsb
Copy link
Contributor

childsb commented Sep 5, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 5, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: childsb, RenaudWasTaken, saad-ali, vishh, vladimirvivien

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@childsb
Copy link
Contributor

childsb commented Sep 5, 2018

/kind feature

@k8s-ci-robot k8s-ci-robot added the kind/feature Categorizes issue or PR as related to a new feature. label Sep 5, 2018
@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here: https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md.

@k8s-github-robot k8s-github-robot merged commit 70a0089 into kubernetes:master Sep 5, 2018
@ChiuWang ChiuWang mentioned this pull request Sep 6, 2018
Merged
@mkimuram mkimuram mentioned this pull request Sep 10, 2018
Closed
@RenaudWasTaken RenaudWasTaken deleted the pluginwatcher-beta branch September 24, 2018 13:25
@adisky adisky mentioned this pull request Sep 27, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vishh vishh vishh left review comments

@vladimirvivien vladimirvivien vladimirvivien left review comments

@saad-ali saad-ali saad-ali approved these changes

@jiayingz jiayingz Awaiting requested review from jiayingz

@sbezverk sbezverk Awaiting requested review from sbezverk

@vikaschoudhary16 vikaschoudhary16 Awaiting requested review from vikaschoudhary16

Assignees

@childsb childsb

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/kubelet cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.12
Development

Successfully merging this pull request may close these issues.

Kubelet Device Plugin Registration
9 participants
@RenaudWasTaken @saad-ali @k8s-ci-robot @vishh @verult @fejta-bot @vladimirvivien @childsb @k8s-github-robot