Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix default config option #66557

Closed
wants to merge 1 commit into from
Closed

Fix default config option #66557

wants to merge 1 commit into from

Conversation

tanshanshan
Copy link

@tanshanshan tanshanshan commented Jul 24, 2018 •
edited
Loading

What this PR does / why we need it:
Fix todo

option Authentication uses apiserveroptions.NewDelegatingAuthenticationOptions() instead of nil
and
option Authorization uses apiserveroptions.NewDelegatingAuthorizationOptions() instead of nil

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. labels Jul 24, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: tanshanshan
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approvers: andrewsykim, deads2k, k82cn

If they are not already assigned, you can assign the PR to them by writing /assign @andrewsykim @deads2k @k82cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 24, 2018
luxas
luxas reviewed Jul 24, 2018
View reviewed changes
Copy link
Member

@luxas luxas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/assign @andrewsykim @sttts

@tanshanshan
Copy link
Author

/retest

@k8s-ci-robot
Copy link
Contributor

@tanshanshan: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-integration febf6e1 link /test pull-kubernetes-integration
pull-kubernetes-e2e-kops-aws febf6e1 link /test pull-kubernetes-e2e-kops-aws
pull-kubernetes-e2e-gce febf6e1 link /test pull-kubernetes-e2e-gce
pull-kubernetes-e2e-gce-device-plugin-gpu febf6e1 link /test pull-kubernetes-e2e-gce-device-plugin-gpu
pull-kubernetes-kubemark-e2e-gce-big febf6e1 link /test pull-kubernetes-kubemark-e2e-gce-big
pull-kubernetes-e2e-gce-100-performance febf6e1 link /test pull-kubernetes-e2e-gce-100-performance

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@sttts
Copy link
Contributor

sttts commented Jul 25, 2018

These are nil intentionally. #64149 enables them including enabling https on a new port.

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 25, 2018
@sttts
Copy link
Contributor

sttts commented Jul 25, 2018

@tanshanshan pinged you on slack

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luxas luxas luxas left review comments

@aveshagarwal aveshagarwal Awaiting requested review from aveshagarwal

Assignees

@sttts sttts

@andrewsykim andrewsykim

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@tanshanshan @k8s-ci-robot @sttts @luxas @andrewsykim