There is already #6569 in flight.
But I'm fine with your approach if you do the same for scheduler.

I'd prefer the name "max_outgoing_qps" and I prefer the approach in #6569. But I think #6569 is running on European time, so you can probably win the race if you want to update this.

I don't think this parameter matters in practice for scheduler (yet), but it's good to have it in everything that's an apiserver client for completeness/consistency.

@lavalamp This parameter matter for scheduler as well - without any limits scheduler is able to scheduler even up to 15 pod per second, but with the current default limit set to 5 it cannot schedule more than 2-3 pods per second (which I think is below our expectations). So we definitely want to change it for the scheduler too.

I'll have a roll up shortly including details from #6569

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.

• If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
• If you signed the CLA as a corporation, please let us know the company's name.

@wojtek-t oh, you're saying the scheduler has a limit right now? I agree it definitely should not be that low. Scheduler doesn't really need a limit IMO, it can't dos apiserver given its current algorithm. So it should be high, like 50 QPS...

updated per review, I wait for feedback b4 final updates.

Looking good, two minor quibbles

Also, gofmt :)

LGTM (we can tune the limit in the future if necessary).
Since all the comments by @lavalamp are applied, I'm kicking Shippable since it's red now and will merge on green.

@timothysc Ohh - actually can you please squash commits before I merge it? Thanks

squashed.

Thanks - will merge on green (we can tune the values in the future).

+1.