Implementing logic for v1beta1.Event API #65782

yastij · 2018-07-03T20:30:33Z

What this PR does / why we need it: This PR implements kubernetes/enhancements#383 API logic. migration of relevent controller will follow after this PR

Which issue(s) this PR fixes : Fixes #56694

Special notes for your reviewer:

Release note:

Implementing deduplication logic for v1beta1.Event API

yastij · 2018-07-03T20:30:51Z

/assign @timothysc @wojtek-t

idealhack · 2018-07-04T01:47:42Z

/ok-to-test

timothysc · 2018-07-13T21:01:42Z

/cc @kubernetes/sig-api-machinery-pr-reviews

wojtek-t · 2018-07-14T09:15:46Z

/assign @gmarek

fejta-bot · 2018-10-12T09:24:00Z

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

yastij · 2018-10-12T14:20:32Z

/remove-lifecycle stale

wojtek-t · 2018-10-16T12:21:47Z

@yastij - what's the status of this PR?
It's marked as WIP so I would like to understand its status and how do you expect to proceed with this.

k8s-ci-robot · 2019-05-13T15:27:16Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

wojtek-t

Please don't resolve comments - especially given most of them are still not addressed.

Most of them are from the previous round are not addressed - I'm not going to take another round of review until you those will be addressed.

staging/src/k8s.io/client-go/tools/events/event_broadcaster.go

wojtek-t · 2019-05-13T18:22:35Z

staging/src/k8s.io/client-go/tools/events/event_broadcaster.go

+	eventBroadcaster.mu.RLock()
+	defer eventBroadcaster.mu.RUnlock()
+	for _, event := range eventBroadcaster.eventCache {
+


staging/src/k8s.io/client-go/tools/events/event_broadcaster.go

staging/src/k8s.io/client-go/tools/events/event_recorder.go

staging/src/k8s.io/client-go/tools/events/interfaces.go

staging/src/k8s.io/client-go/tools/events/event_broadcaster.go

staging/src/k8s.io/client-go/tools/events/event_recorder.go

staging/src/k8s.io/client-go/tools/events/interfaces.go

staging/src/k8s.io/client-go/tools/events/event_broadcaster.go

staging/src/k8s.io/client-go/tools/events/interfaces.go

yastij · 2019-05-16T12:36:35Z

/retest

staging/src/k8s.io/client-go/tools/events/event_broadcaster.go

staging/src/k8s.io/client-go/tools/events/eventseries_test.go

staging/src/k8s.io/client-go/tools/events/interfaces.go

staging/src/k8s.io/client-go/tools/events/eventseries_test.go

yastij · 2019-05-16T16:24:12Z

@wojtek-t - updated and squashed.

Signed-off-by: Yassine TIJANI <ytijani@vmware.com>

yastij · 2019-05-17T09:19:45Z

/retest

wojtek-t · 2019-05-17T10:36:49Z

/lgtm
/approve

Let's have this merged and iterate on this further.

k8s-ci-robot · 2019-05-17T10:37:22Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wojtek-t, yastij

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~staging/publishing/OWNERS~~ [wojtek-t]
~~staging/src/k8s.io/client-go/OWNERS~~ [wojtek-t]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

staging/src/k8s.io/client-go/tools/events/event_broadcaster.go

tedyu · 2019-05-17T16:39:17Z

I have created #78040 for the above points.

Implementing logic for v1beta1.Event API Kubernetes-commit: e67c266

k8s-ci-robot requested review from nikhiljindal and nikhita July 3, 2018 20:30

k8s-ci-robot assigned timothysc and wojtek-t Jul 3, 2018

k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jul 4, 2018

k8s-ci-robot added the sig/api-machinery Categorizes an issue or PR as relevant to SIG API Machinery. label Jul 13, 2018

timothysc removed their assignment Jul 13, 2018

k8s-ci-robot assigned gmarek Jul 14, 2018

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 12, 2018

k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 12, 2018

yastij force-pushed the eventv2-eventf branch from d0d19f8 to a77b0cf Compare October 22, 2018 20:15

yastij changed the title ~~WIP: Implementing logic for v1beta1.Event API~~ Implementing logic for v1beta1.Event API Oct 22, 2018

k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 22, 2018

k8s-ci-robot assigned sttts Oct 22, 2018

yastij force-pushed the eventv2-eventf branch from a77b0cf to 8ff4379 Compare October 22, 2018 21:54

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 10, 2018

yastij force-pushed the eventv2-eventf branch from 8ff4379 to cae158e Compare December 28, 2018 15:42

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Dec 28, 2018

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels May 13, 2019

wojtek-t reviewed May 13, 2019

View reviewed changes

yastij force-pushed the eventv2-eventf branch 3 times, most recently from 1c32a26 to b37f793 Compare May 13, 2019 20:39

wojtek-t reviewed May 14, 2019

View reviewed changes

wojtek-t reviewed May 16, 2019

View reviewed changes

yastij force-pushed the eventv2-eventf branch from a36bb05 to 1052f8d Compare May 16, 2019 11:33

wojtek-t reviewed May 16, 2019

View reviewed changes

yastij force-pushed the eventv2-eventf branch from 1052f8d to 8cbd732 Compare May 16, 2019 16:23

yastij force-pushed the eventv2-eventf branch from 8cbd732 to 93a5333 Compare May 16, 2019 17:17

Implementing logic for v1beta1.Event API

464a994

Signed-off-by: Yassine TIJANI <ytijani@vmware.com>

yastij force-pushed the eventv2-eventf branch from 93a5333 to 464a994 Compare May 17, 2019 08:51

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 17, 2019

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2019

k8s-ci-robot merged commit e67c266 into kubernetes:master May 17, 2019

tedyu reviewed May 17, 2019

View reviewed changes

staging/src/k8s.io/client-go/tools/events/event_broadcaster.go Show resolved Hide resolved

staging/src/k8s.io/client-go/tools/events/event_broadcaster.go Show resolved Hide resolved

staging/src/k8s.io/client-go/tools/events/event_broadcaster.go Show resolved Hide resolved

tedyu mentioned this pull request May 17, 2019

Use lock in eventBroadcasterImpl#refreshExistingEventSeries #78040

Merged

nikhita pushed a commit to nikhita/kubernetes that referenced this pull request Jun 13, 2019

Merge pull request kubernetes#65782 from yastij/eventv2-eventf

7238bed

Implementing logic for v1beta1.Event API Kubernetes-commit: e67c266

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implementing logic for v1beta1.Event API #65782

Implementing logic for v1beta1.Event API #65782

yastij commented Jul 3, 2018 •

edited

Loading

yastij commented Jul 3, 2018

idealhack commented Jul 4, 2018

timothysc commented Jul 13, 2018

wojtek-t commented Jul 14, 2018

fejta-bot commented Oct 12, 2018

yastij commented Oct 12, 2018

wojtek-t commented Oct 16, 2018

k8s-ci-robot commented May 13, 2019

wojtek-t left a comment

wojtek-t May 13, 2019

yastij commented May 16, 2019

yastij commented May 16, 2019

yastij commented May 17, 2019

wojtek-t commented May 17, 2019

k8s-ci-robot commented May 17, 2019

tedyu commented May 17, 2019

Implementing logic for v1beta1.Event API #65782

Implementing logic for v1beta1.Event API #65782

Conversation

yastij commented Jul 3, 2018 • edited Loading

yastij commented Jul 3, 2018

idealhack commented Jul 4, 2018

timothysc commented Jul 13, 2018

wojtek-t commented Jul 14, 2018

fejta-bot commented Oct 12, 2018

yastij commented Oct 12, 2018

wojtek-t commented Oct 16, 2018

k8s-ci-robot commented May 13, 2019

wojtek-t left a comment

Choose a reason for hiding this comment

wojtek-t May 13, 2019

Choose a reason for hiding this comment

yastij commented May 16, 2019

yastij commented May 16, 2019

yastij commented May 17, 2019

wojtek-t commented May 17, 2019

k8s-ci-robot commented May 17, 2019

tedyu commented May 17, 2019

yastij commented Jul 3, 2018 •

edited

Loading