Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix exec/portforward minions->nodes #6516

Merged
merged 1 commit into from
Apr 7, 2015
Merged

Fix exec/portforward minions->nodes #6516

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix exec/portforward minions->nodes 
Exec and port forward weren't working with v1beta3 because they were
proxying minions. Change minions to nodes. This appears to work with
v1beta1 and v1beta2 as well.
  • Loading branch information
Andy Goldstein committed Apr 7, 2015
commit 1c92133b7725eec9b281a2cc07295b62adc0ff27
2 changes: 1 addition & 1 deletion pkg/kubectl/cmd/exec.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ func RunExec(f *Factory, cmdIn io.Reader, cmdOut, cmdErr io.Writer, cmd *cobra.C

req := client.RESTClient.Get().
Prefix("proxy").
Resource("minions").
Resource("nodes").
Name(pod.Spec.Host).
Suffix("exec", namespace, podName, containerName)

Expand Down
2 changes: 1 addition & 1 deletion pkg/kubectl/cmd/portforward.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ func RunPortForward(f *Factory, cmd *cobra.Command, args []string) error {

req := client.RESTClient.Get().
Prefix("proxy").
Resource("minions").
Resource("nodes").
Name(pod.Spec.Host).
Suffix("portForward", namespace, podName)

Expand Down