Load docker images of kubernetes components after docker is installed. #6496

ArtfulCoder · 2015-04-07T01:18:45Z

#6465

ArtfulCoder · 2015-04-07T01:27:40Z

@derekwaynecarr can you check if this PR works with Vagrant ?

@dchen1107

#6471

derekwaynecarr · 2015-04-07T01:45:13Z

Will report back with results

ArtfulCoder · 2015-04-07T16:50:24Z

@derekwaynecarr did you get a chance to try it. thanks!

derekwaynecarr · 2015-04-07T16:54:57Z

not yet, will try this afternoon and reply.

derekwaynecarr · 2015-04-07T18:12:54Z

cluster/saltbase/salt/docker/init.sls

@@ -104,9 +104,24 @@ lxc-docker-{{ docker_ver }}:
    - sources:
      - lxc-docker-{{ docker_ver }}: /var/cache/docker-install/{{ deb }}

+docker_load_kube_apiserver:


These functions are stuck in a if/else block that is only called if you are not running in a Red Hat based linux distro, so they are never called. I am testing this by moving it to the top of the function.

ArtfulCoder · 2015-04-07T18:22:11Z

@derekwaynecarr I update the PR based on your feedback.

derekwaynecarr · 2015-04-07T18:33:37Z

So it doesn't fail, but when I ssh into the master and run 'sudo docker images', I do not see the images reported. If I manually run the command to load the tars 'sudo docker load -i ...' , the images load fine.

ArtfulCoder · 2015-04-07T18:44:43Z

I am trying to start my own vagrant cluster.
I think even though salt thinks that docker service is running, docker might not have fully initialized
Hence, when you tried later, it worked.
if you check the /var/log/startupscript.log file, you should see errors.

derekwaynecarr · 2015-04-07T18:47:42Z

I am happy to debug further. Ping me on IRC

derekwaynecarr · 2015-04-07T19:21:25Z

As structured, this code attempts to load the images on the master and the minions. Is this desired? It causes error on subsequent kube-push calls when each minion tries to run the command.

==> master: kubernetes-minion-1:
==> master: ----------
==> master:           ID: docker_load_kube_apiserver
==> master:     Function: cmd.run
==> master:         Name: docker load -i /srv/salt/kube-bins/kube-apiserver.tar
==> master:       Result: False
==> master:      Comment: Command "docker load -i /srv/salt/kube-bins/kube-apiserver.tar" run
==> master:      Started: 19:19:04.119813
==> master:     Duration: 60.291 ms
==> master:      Changes:   
==> master:               ----------
==> master:               pid:
==> master:                   23439
==> master:               retcode:
==> master:                   1
==> master:               stderr:
==> master:                   time="2015-04-07T19:19:04Z" level="fatal" msg="open /srv/salt/kube-bins/kube-apiserver.tar: no such file or directory"
==> master:               stdout:
==> master:

derekwaynecarr · 2015-04-07T19:22:28Z

It looks like on initial kube-up, docker is not found for some reason yet when the command runs.

It looks on subsequent kube-push, the images are loaded correctly on the master, but there is an error reported by salt on each minion as defined above.

derekwaynecarr · 2015-04-07T19:23:34Z

Would it be better to push this into its own sls file kind of like we do for kube-addons so this can only run on the master?

derekwaynecarr · 2015-04-07T20:59:09Z

Trying again, will report back with success/fail. Is the goal for this image to be on each minion though?

derekwaynecarr · 2015-04-08T14:34:40Z

LGTM

ArtfulCoder · 2015-04-08T15:02:40Z

@derekwaynecarr I am going to address your previous comments about loading images only on master.
I will update the PR today (hopefully)

ArtfulCoder · 2015-04-09T16:10:19Z

@derekwaynecarr
PTAL
I have verified it on GCE and vagrant.
container images are installed only on the master.

ArtfulCoder · 2015-04-09T17:19:23Z

#5011

ArtfulCoder · 2015-04-10T16:28:17Z

@thockin PTAL
Thanks!

derekwaynecarr · 2015-04-10T19:52:10Z

Trying this now.

derekwaynecarr · 2015-04-10T20:19:05Z

works great, LGTM.

Load docker images of kubernetes components after docker is installed.

ArtfulCoder · 2015-04-10T20:37:32Z

Thanks!!

Sent from my iPhone

On Apr 10, 2015, at 1:19 PM, Derek Carr notifications@github.com wrote:

Merged #6496.

—
Reply to this email directly or view it on GitHub.

zmerlynn · 2015-04-15T17:19:49Z

cluster/saltbase/salt/kube-master-addons/kube-master-addons.sh

+# limitations under the License.
+
+ while true; do
+  if which docker 1>/dev/null 2>&1; then


Isn't spinwaiting? :) You might want a sleep in here.

@zmerlynn
Thanks for the catch! created a PR #6955

googlebot added the cla: yes label Apr 7, 2015

ArtfulCoder assigned ArtfulCoder and zmerlynn and unassigned ArtfulCoder Apr 7, 2015

derekwaynecarr reviewed Apr 7, 2015
View reviewed changes

ArtfulCoder force-pushed the docker_image_install branch from bdde589 to 9327694 Compare April 7, 2015 18:21

ArtfulCoder force-pushed the docker_image_install branch from 9327694 to e8c2c82 Compare April 7, 2015 18:23

ArtfulCoder force-pushed the docker_image_install branch from e8c2c82 to dbfda90 Compare April 7, 2015 18:53

ArtfulCoder force-pushed the docker_image_install branch from dbfda90 to c5c2e87 Compare April 7, 2015 20:30

ArtfulCoder unassigned zmerlynn Apr 8, 2015

vishh assigned derekwaynecarr Apr 8, 2015

Load docker images of kubernetes components after docker is installed.

4996ccb

ArtfulCoder force-pushed the docker_image_install branch from c5c2e87 to 4996ccb Compare April 9, 2015 16:07

derekwaynecarr added a commit that referenced this pull request Apr 10, 2015

Merge pull request #6496 from ArtfulCoder/docker_image_install

d2b6920

Load docker images of kubernetes components after docker is installed.

derekwaynecarr merged commit d2b6920 into kubernetes:master Apr 10, 2015

zmerlynn reviewed Apr 15, 2015
View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Load docker images of kubernetes components after docker is installed. #6496

Load docker images of kubernetes components after docker is installed. #6496

ArtfulCoder commented Apr 7, 2015

ArtfulCoder commented Apr 7, 2015

derekwaynecarr commented Apr 7, 2015

ArtfulCoder commented Apr 7, 2015

derekwaynecarr commented Apr 7, 2015

derekwaynecarr Apr 7, 2015

ArtfulCoder commented Apr 7, 2015

derekwaynecarr commented Apr 7, 2015

ArtfulCoder commented Apr 7, 2015

derekwaynecarr commented Apr 7, 2015

derekwaynecarr commented Apr 7, 2015

derekwaynecarr commented Apr 7, 2015

derekwaynecarr commented Apr 7, 2015

derekwaynecarr commented Apr 7, 2015

derekwaynecarr commented Apr 8, 2015

ArtfulCoder commented Apr 8, 2015

ArtfulCoder commented Apr 9, 2015

ArtfulCoder commented Apr 9, 2015

ArtfulCoder commented Apr 10, 2015

derekwaynecarr commented Apr 10, 2015

derekwaynecarr commented Apr 10, 2015

ArtfulCoder commented Apr 10, 2015

zmerlynn Apr 15, 2015

ArtfulCoder Apr 17, 2015

Load docker images of kubernetes components after docker is installed. #6496

Load docker images of kubernetes components after docker is installed. #6496

Conversation

ArtfulCoder commented Apr 7, 2015

ArtfulCoder commented Apr 7, 2015

derekwaynecarr commented Apr 7, 2015

ArtfulCoder commented Apr 7, 2015

derekwaynecarr commented Apr 7, 2015

derekwaynecarr Apr 7, 2015

Choose a reason for hiding this comment

ArtfulCoder commented Apr 7, 2015

derekwaynecarr commented Apr 7, 2015

ArtfulCoder commented Apr 7, 2015

derekwaynecarr commented Apr 7, 2015

derekwaynecarr commented Apr 7, 2015

derekwaynecarr commented Apr 7, 2015

derekwaynecarr commented Apr 7, 2015

derekwaynecarr commented Apr 7, 2015

derekwaynecarr commented Apr 8, 2015

ArtfulCoder commented Apr 8, 2015

ArtfulCoder commented Apr 9, 2015

ArtfulCoder commented Apr 9, 2015

ArtfulCoder commented Apr 10, 2015

derekwaynecarr commented Apr 10, 2015

derekwaynecarr commented Apr 10, 2015

ArtfulCoder commented Apr 10, 2015

zmerlynn Apr 15, 2015

Choose a reason for hiding this comment

ArtfulCoder Apr 17, 2015

Choose a reason for hiding this comment