Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify --hostname-override and --cloud-provider interaction #64661

Merged
merged 1 commit into from
Jun 4, 2018
Merged

Clarify --hostname-override and --cloud-provider interaction #64661

merged 1 commit into from
Jun 4, 2018

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jun 2, 2018 •
edited
Loading

pairs with a PR to the website cloud provider page defining behavior for existing cloud providers: kubernetes/website#8873

xref #64659 #62600 #61774 #54482

NONE

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 2, 2018
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jun 2, 2018
@dims
Copy link
Member

dims commented Jun 2, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2018
@liggitt liggitt mentioned this pull request Jun 2, 2018
Closed
@liggitt
Copy link
Member Author

liggitt commented Jun 3, 2018

/retest

@liggitt
Copy link
Member Author

liggitt commented Jun 3, 2018

@kubernetes/sig-node-pr-reviews

@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Jun 3, 2018
@liggitt liggitt added the kind/documentation Categorizes issue or PR as related to documentation. label Jun 3, 2018
feiskyer
feiskyer reviewed Jun 3, 2018
View reviewed changes
Copy link
Member

@feiskyer feiskyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jhorwit2
jhorwit2 reviewed Jun 3, 2018
View reviewed changes
cmd/kubelet/app/options/options.go
@@ -366,7 +366,7 @@ func (f *KubeletFlags) AddFlags(mainfs *pflag.FlagSet) {
fs.StringVar(&f.CertDirectory, "cert-dir", f.CertDirectory, "The directory where the TLS certs are located. "+
"If --tls-cert-file and --tls-private-key-file are provided, this flag will be ignored.")

fs.StringVar(&f.CloudProvider, "cloud-provider", f.CloudProvider, "The provider for cloud services. Specify empty string for running with no cloud provider.")
fs.StringVar(&f.CloudProvider, "cloud-provider", f.CloudProvider, "The provider for cloud services. Specify empty string for running with no cloud provider. If set, the cloud provider determines the name of the node (consult cloud provider documentation to determine if and how the hostname is used).")
Copy link
Contributor

@jhorwit2 jhorwit2 Jun 3, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If set, the cloud provider determines the name of the node

That's not true is it? The cloud provider will only set the address of type hostname; not change the nodes name.

edit: Sorry, I'm explicitly talking about when cloud provider is external.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cloud provider does determine the node name. Some use the detected or overridden hostname to do so, some don't.

Copy link
Member Author

@liggitt liggitt Jun 3, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See kubernetes/website#8873 for descriptions of how each cloud provider determines the node name. Can update that with the behavior of the kubelet for --cloud-provider=external

@dims
Copy link
Member

dims commented Jun 4, 2018

/milestone v1.11

@k8s-ci-robot k8s-ci-robot added this to the v1.11 milestone Jun 4, 2018
@dims
Copy link
Member

dims commented Jun 4, 2018

/assign @Random-Liu
/assign @yujuhong

/priority important-soon
/kind cleanup

@k8s-ci-robot k8s-ci-robot added the priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. label Jun 4, 2018
@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Jun 4, 2018
@dims
Copy link
Member

dims commented Jun 4, 2018

/status approved-for-milestone

@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@Random-Liu @dims @liggitt @yujuhong

Pull Request Labels
  • sig/node: Pull Request will be escalated to these SIGs if needed.
  • priority/important-soon: Escalate to the pull request owners and SIG owner; move out of milestone after several unsuccessful escalation attempts.
  • kind/cleanup: Adding tests, refactoring, fixing old bugs.
Help

@yujuhong
Copy link
Contributor

yujuhong commented Jun 4, 2018

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, liggitt, yujuhong

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 4, 2018
@k8s-github-robot
Copy link

Automatic merge from submit-queue (batch tested with PRs 63453, 64592, 64482, 64618, 64661). If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit 50178d3 into kubernetes:master Jun 4, 2018
@liggitt liggitt deleted the hostname-override branch June 6, 2018 15:44
@seh seh mentioned this pull request Nov 25, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jhorwit2 jhorwit2 jhorwit2 left review comments

@feiskyer feiskyer feiskyer left review comments

@derekwaynecarr derekwaynecarr Awaiting requested review from derekwaynecarr

Assignees

@dims dims

@Random-Liu Random-Liu

@yujuhong yujuhong

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/documentation Categorizes issue or PR as related to documentation. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/important-soon Must be staffed and worked on either currently, or very soon, ideally in time for the next release. release-note-none Denotes a PR that doesn't merit a release note. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.11
Development

Successfully merging this pull request may close these issues.
8 participants
@liggitt @dims @k8s-github-robot @yujuhong @k8s-ci-robot @feiskyer @jhorwit2 @Random-Liu