Declare kubectl wait flag in a way consistent with other deletion flags #64375
Conversation
|
@nilebox: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
do-not-merge/work-in-progress
|
/area kubectl |
k8s-ci-robot
added
sig/cli
pkg/kubectl/cmd/delete.go
Outdated
| // To preserve backwards compatibility, but prevent accidental data loss, we convert --grace-period=0 | ||
| // into --grace-period=1 and wait until the object is successfully deleted. Users may provide --force | ||
| // to bypass this wait. | ||
| o.WaitForDeletion = true |
There was a problem hiding this comment.
comment above needs adjustment.
| if f.Output != nil { | ||
| cmd.Flags().StringVarP(f.Output, "output", "o", *f.Output, "Output mode. Use \"-o name\" for shorter output (resource/name).") | ||
| } | ||
|
|
There was a problem hiding this comment.
no need for this whitespace change.
There was a problem hiding this comment.
sure, but I don't see any value in keeping it.
pkg/kubectl/cmd/delete_flags.go
Outdated
| @@ -211,5 +219,6 @@ func NewDeleteFlags(usage string) *DeleteFlags { | |||
| // add non-defaults | |||
| Force: &force, | |||
| Timeout: &timeout, | |||
| Wait: &wait, | |||
There was a problem hiding this comment.
please, align it to the above param values.
nilebox
force-pushed
the
delete-wait-cleanup
branch
2 times, most recently
from
4a1d473 to
d4fdae8
Compare
|
/ok-to-test |
k8s-ci-robot
removed
the
needs-ok-to-test
nilebox
changed the title
k8s-ci-robot
removed
the
do-not-merge/work-in-progress
|
/sig CLI |
|
/test pull-kubernetes-kubemark-e2e-gce |
nilebox
changed the title
soltysh
added
release-note-none
|
This lgtm, please squash your changes into a single commit and I'll merge it. |
nilebox
force-pushed
the
delete-wait-cleanup
branch
from
fe6c4e1 to
acc5dd4
Compare
nilebox
force-pushed
the
delete-wait-cleanup
branch
from
acc5dd4 to
6f1b178
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
@nilebox: Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
k8s-ci-robot
added
do-not-merge/release-note-label-needed
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dixudx, nilebox, soltysh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
[MILESTONENOTIFIER] Milestone Pull Request Labels Incomplete Action required: This pull request requires label changes. If the required changes are not made within 3 days, the pull request will be moved out of the v1.11 milestone. kind: Must specify exactly one of |
soltysh
added
release-note-none
|
Automatic merge from submit-queue (batch tested with PRs 64300, 64375). If you want to cherry-pick this change to another branch, please follow the instructions here. |
What this PR does / why we need it:
A follow up PR for #64034 and #63979 that makes declaring wait flag consistent with the other flags.
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)format, will close the issue(s) when PR gets merged):Fixes #64401
Special notes for your reviewer:
Release note: