-
Notifications
You must be signed in to change notification settings - Fork 40.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump grpc max message size for docker service #63894
Bump grpc max message size for docker service #63894
Conversation
/assign @Random-Liu |
I think it is OK as a temporary solution. Perhaps, it can have a final solution, like stream output message, result pagination or something else. |
@ceshihao it's a WIP to see if this helps this specific scenario that fails, if it does, then we can try to figure out how to turn it into something acceptable |
Great, thanks.
…On Wed, May 16, 2018 at 9:33 AM, Davanum Srinivas ***@***.***> wrote:
@ceshihao <https://github.com/ceshihao> it's a WIP to see if this helps
this specific scenario that fails, if it does, then we can try to figure
out how to turn it into something acceptable
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#63894 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHWsg6WwAo_I_JrhpL7tjPgTmIeUntFcks5ty4ICgaJpZM4UAY8k>
.
|
525eb04
to
eb6bd67
Compare
/assign @derekwaynecarr |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/retest |
/test pull-kubernetes-e2e-gce |
I think bumping the limit is reasonable (although maybe we should have a more concrete example to reason able the size). As for a long-term solution such as pagination, I am not against the idea, but do feel like we need a better justification (e.g., expected #containers and the size of each container) for adding the complexity. /approve |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, feiskyer, yujuhong The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all [submit-queue is verifying that this PR is safe to merge] |
Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here. |
@dims can this be cherry-picked for 1.10 release? |
@mkumatag Done! |
What this PR does / why we need it:
When we have a lot of containers, we run into the limit in grpc ( https://github.com/grpc/grpc-go/blob/master/clientconn.go#L118 )
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged):Fixes #63858
Special notes for your reviewer:
In #63977 we fixed the send and receive sizes on the client side. we should fix the docker service too
Release note: