Configure the kubelet to use HTTPS (take 2) #6380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heapster can collect metrics. Update the heapster config to point to the non-secured port.
|
Monitoring changes LGTM. |
|
ping @erictune |
|
lgtm |
erictune
added a commit
that referenced
this pull request
Apr 3, 2015
Configure the kubelet to use HTTPS (take 2)
AntonioMeireles
added a commit
to AntonioMeireles/kube-register
that referenced
this pull request
Apr 14, 2015
this works, not sure if this a good idea, as is, as probably one should look at both new (10248) and previous (10250) ports for /healthz. OTOH one can now set a la carte healthz ports in the minions' kubelet ( via --healthz_port ) so one must also handle that, long term. Signed-off-by: António Meireles <antonio.meireles@reformi.st>
AntonioMeireles
added a commit
to AntonioMeireles/kubernetes-vagrant-coreos-cluster
that referenced
this pull request
Apr 14, 2015
[basically kubernetes/kubernetes#6380] Signed-off-by: António Meireles <antonio.meireles@reformi.st>
AntonioMeireles
added a commit
to AntonioMeireles/kubernetes-vagrant-coreos-cluster
that referenced
this pull request
Apr 14, 2015
cf. kelseyhightower/kube-register#15 (from kubernetes/kubernetes#6380) Signed-off-by: António Meireles <antonio.meireles@reformi.st>
AntonioMeireles
added a commit
to AntonioMeireles/kubernetes-vagrant-coreos-cluster
that referenced
this pull request
Apr 14, 2015
(due again to kubernetes/kubernetes#6380) Signed-off-by: António Meireles <antonio.meireles@reformi.st>
This was referenced Jun 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've added a new read-only HTTP port on the Kubelet specifically for use by Heapster until we reconfigure Heapster to connect to the TLS port. I ran the "Monitoring verify monitoring pods and all cluster nodes are available on influxdb using heapster" e2e test 10 times in a row with no failures.
I left this as two commits so it would be simple to see what was different from #6243 but I'm happy to squish them before this is merged.
/cc @vishh