Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating components to use v1beta3 #6377

Merged
merged 1 commit into from
Apr 3, 2015
Merged

Updating components to use v1beta3 #6377

merged 1 commit into from
Apr 3, 2015

Conversation

nikhiljindal
Copy link
Contributor

For #5475

  • Setting the default version in clientcmds to v1beta3
  • Updating api.Latest to point to v1beta3 instead of v1beta1

@nikhiljindal
Copy link
Contributor Author

@bgrant0607 Verified that unit and integration tests pass.
Working on e2e tests.

bgrant0607
bgrant0607 reviewed Apr 2, 2015
View reviewed changes
pkg/client/request.go
@@ -558,6 +558,7 @@ func (r *Request) DoRaw() ([]byte, error) {

var err error
r.req, err = http.NewRequest(r.verb, r.finalURL(), r.body)
glog.Errorf("REQUEST TO URL: %s", r.finalURL())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Was this for debugging?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert this change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reverted

@bgrant0607
Copy link
Member

What does this affect? Does it change the storage version?

@bgrant0607 bgrant0607 self-assigned this Apr 2, 2015
@nikhiljindal
Copy link
Contributor Author

Yes it affects storage version as well: https://github.com/GoogleCloudPlatform/kubernetes/blob/96a0a0d6189cf89f13f700bb5fa6c8f47aa109e5/pkg/master/master.go#L179

bgrant0607
bgrant0607 reviewed Apr 3, 2015
View reviewed changes
hack/e2e-test.sh
@@ -15,6 +15,6 @@
# limitations under the License.

# Provided for backwards compatibility
go run "$(dirname $0)/e2e.go" -v -build -up -test -down
go run "$(dirname $0)/e2e.go" -v -up -test -down
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this change?

@bgrant0607
Copy link
Member

Regenerate or revert the kubectl docs.

@nikhiljindal nikhiljindal force-pushed the kubevtl branch 4 times, most recently from 9937633 to dc33f3c Compare April 3, 2015 22:02
@nikhiljindal
Copy link
Contributor Author

I think I have fixed all e2e tests now.

All but 3 tests are passing. The ones failing seem to be flaky on head as well:

Test: ReplicationController should serve a basic image on each replica with a private image
Error: Controller my-hostname-private-6e4c6f9f-da4e-11e4-998e-6c3be516adae: Gave up waiting for hostIP of replica 0 after 121.03349215 seconds

Test: ReplicationController should serve a basic image on each replica with a public image
Error: Controller my-hostname-basic-bbac7616-da4e-11e4-998e-6c3be516adae: Gave up waiting for hostIP of replica 0 after 121.041411761 seconds

Test: Monitoring verify monitoring pods and all cluster nodes are available on influxdb using heapster.
Error: monitoring using heapster and influxdb test failed

@nikhiljindal
Copy link
Contributor Author

Cleaned up the PR and reverted the kubectl docs. Please have another look.

@vishh
Copy link
Contributor

vishh commented Apr 3, 2015

@nikhiljindal: The monitoring test has not been flaky for the last few days. I would suggest looking into why its failing.

bgrant0607
bgrant0607 reviewed Apr 3, 2015
View reviewed changes
cluster/vagrant/util.sh
@@ -165,7 +165,7 @@ function verify-cluster {
local count="0"
until [[ "$count" == "1" ]]; do
local minions
minions=$("${KUBE_ROOT}/cluster/kubectl.sh" get minions -o template -t '{{range.items}}{{.id}}:{{end}}')
minions=$("${KUBE_ROOT}/cluster/kubectl.sh" get minions -o template -t '{{range.items}}{{.id}}:{{end}}' --api-version=v1beta1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why you didn't change this similarly to validate-cluster.sh? The inability to test the change?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I decided to change them in a separate PR.
We will have to change these for deleting v1beta1

@nikhiljindal
Copy link
Contributor Author

@vishh The monitoring test failed in the last build on jenkins with the same error: http://kubekins.dls.corp.google.com/job/kubernetes-e2e-gce/lastSuccessfulBuild/

@bgrant0607
Copy link
Member

LGTM.

bgrant0607 added a commit that referenced this pull request Apr 3, 2015
@bgrant0607
Merge pull request #6377 from nikhiljindal/kubevtl
b0b6418 
Updating components to use v1beta3
@bgrant0607 bgrant0607 merged commit b0b6418 into kubernetes:master Apr 3, 2015
@bgrant0607 bgrant0607 mentioned this pull request Apr 6, 2015
Closed
16 tasks
@nikhiljindal nikhiljindal mentioned this pull request Apr 8, 2015
Merged
@caesarxuchao caesarxuchao mentioned this pull request Apr 29, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@bgrant0607 bgrant0607

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikhiljindal @bgrant0607 @vishh @googlebot