Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #59291: Remove validation failure of Pod priority when the feature is disabled #63139

Closed
wants to merge 1 commit into from
Closed

Automated cherry pick of #59291: Remove validation failure of Pod priority when the feature is disabled #63139

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Apr 25, 2018 •
edited by k82cn
Loading

Cherry pick of #59291 on release-1.9.

#59291: Remove validation failure of Pod priority when the feature is disabled

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Apr 25, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Apr 25, 2018
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Apr 25, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vainu-arto
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: erictune

Assign the PR to them by writing /assign @erictune in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k82cn k82cn changed the title Automated cherry pick of #59291: Remove validation failure of Pod priority when the feauter is Automated cherry pick of #59291: Remove validation failure of Pod priority when the feature is disabled Apr 26, 2018
@k82cn
Copy link
Member

k82cn commented Apr 26, 2018

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 26, 2018
@k82cn
Copy link
Member

k82cn commented Apr 26, 2018

/release-note-none

@k8s-ci-robot k8s-ci-robot added the release-note-none Denotes a PR that doesn't merit a release note. label Apr 26, 2018
@k82cn
Copy link
Member

k82cn commented Apr 26, 2018

/sig scheduling

@k8s-ci-robot k8s-ci-robot added the sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. label Apr 26, 2018
@ghost
Copy link
Author

ghost commented Apr 30, 2018

/assign @erictune

@mbohlool
Copy link
Contributor

please add a test

@ghost
Copy link
Author

ghost commented May 14, 2018

@mbohlool Do note that this is a cherrypick of a change that has been merged to master and included in releases. I also had no role in the writing of this code, I'd simply benefit from having it usable in releases other than 1.10.

@mbohlool
Copy link
Contributor

@vainu-arto it is fine then. It, however, needs usual lgtm/approvals. Please ping appropriate reviewers. tomorrow is the deadline for the next release. thanks.

@mbohlool mbohlool added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels May 15, 2018
@ghost
Copy link
Author

ghost commented May 15, 2018

@bsalamat @liggitt @tallclair Can you check that this is ok to apply to 1.9?

@liggitt
Copy link
Member

liggitt commented May 15, 2018

there's no need to pick this to 1.9. if the feature is disabled, the field is dropped here, prior to validation:

https://github.com/kubernetes/kubernetes/blob/release-1.9/pkg/api/pod/util.go#L234-L237

@liggitt
Copy link
Member

liggitt commented May 15, 2018

/close

@ghost ghost deleted the automated-cherry-pick-of-#59291-upstream-release-1.9 branch September 17, 2018 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roberthbailey roberthbailey Awaiting requested review from roberthbailey

@vishh vishh Awaiting requested review from vishh

Assignees

@liggitt liggitt

@erictune erictune

Labels
cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. release-note-none Denotes a PR that doesn't merit a release note. sig/scheduling Categorizes an issue or PR as relevant to SIG Scheduling. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@k8s-ci-robot @k82cn @mbohlool @liggitt @erictune @k8s-github-robot @bsalamat