Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup networking e2e + modularize pod launch + annotate nettest #6276

Closed
wants to merge 0 commits into from
Closed

cleanup networking e2e + modularize pod launch + annotate nettest #6276

wants to merge 0 commits into from

Conversation

jayunit100
Copy link
Member

Here's another E2E improvement which I put together as part of the overall e2e improvements we're working on.

  • add a BeforeSuite for testing external connectivity. I don't thinking testing client connectivity (while maybe useful in certain clusters), should clutter the testing logic directly.
  • modularize the reusable portion (creating the pod family used for validating internal networking).
  • comments to clarify what actually the container is expected to do - the nettest container is heavily coupled to this test, so that needs to be noted explicitly.
  • move the tests not needing pod peers to the beginning (no need to spin up pods before testing that the api server is working, and no need for api server tests to have access to information about the pods, either).

@jayunit100 jayunit100 force-pushed the networking-test-reorder branch 2 times, most recently from f8fbab3 to c33f1ef Compare April 1, 2015 14:04
@jayunit100 jayunit100 changed the title Reorder the networking e2e and modularize the pod launching phase cleanup networking e2e + modularize pod launch + annotate nettest Apr 1, 2015
@jayunit100
Copy link
Member Author

this e2e test is being flakey for me, at the moment. Im going to test it 10 times and then will update in this thread. after all --- the e2e's are not in the CI, so want to make sure it really works properly.

@jayunit100
Copy link
Member Author

confirmed that networking.go is flakey. died 90% of the time last night evidently

@jayunit100
Copy link
Member Author

ill rebase this later. looks like something has changed it recently

@bprashanth
Copy link
Contributor

satnam, because he took ownership of e2e during lunch :)

@jayunit100 jayunit100 force-pushed the networking-test-reorder branch from c33f1ef to f12aad3 Compare April 2, 2015 01:44
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for the commit author(s). If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.

@googlebot googlebot added cla: no and removed cla: yes labels Apr 2, 2015
@bgrant0607
Copy link
Member

Not sure what happened, but this PR is now unreviewable. Try rebasing or re-applying your patches to a fresh branch.

Note that the networking test was outright broken last night. #6294

@jayunit100 jayunit100 force-pushed the networking-test-reorder branch from f12aad3 to c316847 Compare April 2, 2015 01:53
@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes and removed cla: no labels Apr 2, 2015
@jayunit100
Copy link
Member Author

finally cleaned up :) sorry about that. This rebases my updates to the networking.go test last night on top of the new one. I've run it twice, working cleanly.

Since E2E tests dont run in the CI, I tested it manually and paste below...........

[jay@rhbd kubernetes]$ go run ./cmd/e2e/e2e.go --provider="local" --host="http://127.0.0.1:8080" -t "Networking" --auth_config=/opt/kube-creds
Running Suite: Kubernetes e2e Suite run 1 of 1
==============================================
Random Seed: 1427939778 - Will randomize all specs
Will run 2 of 35 specs

SSSSSSSSSSSSSSSSSS
------------------------------
Networking 
  should provide unchanging, static URL paths for kubernetes api services.
  /home/jay/gopath/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/networking.go:112
[BeforeEach] Networking
  /home/jay/gopath/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/networking.go:91
[It] should provide unchanging, static URL paths for kubernetes api services.
  /home/jay/gopath/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/networking.go:112
STEP: testing: /validate
STEP: testing: /healthz
•SSSSSSSSSSSSSS
------------------------------
Networking 
  should function for intra-pod communication
  /home/jay/gopath/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/networking.go:254
[BeforeEach] Networking
  /home/jay/gopath/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/networking.go:91
[It] should function for intra-pod communication
  /home/jay/gopath/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/networking.go:254
STEP: Creating a service named [nettest] in namespace nettest-7330
STEP: Creating a webserver (pending) pod on each node
INFO: Creating pod nettest-0 on node 127.0.0.1
STEP: Waiting for the webserver pods to transition to Running state
STEP: waiting up to 5m0s for pod nettest-0 status to be running
INFO: Waiting for pod nettest-0 in namespace nettest-7330 status to be "running" (found "Pending") (7.691174ms)
STEP: Waiting for connectivity to be verified
INFO: About to make a proxy status call
INFO: Proxy status call returned in 2.373466ms
INFO: About to make a proxy status call
INFO: Proxy status call returned in 2.218119ms
INFO: About to make a proxy status call
INFO: Proxy status call returned in 3.001547ms
INFO: Attempt 2/60: test still running
INFO: About to make a proxy status call
INFO: Proxy status call returned in 2.439226ms
INFO: Attempt 3/60: test still running
INFO: About to make a proxy status call
INFO: Proxy status call returned in 1.69572ms
INFO: Passed on attempt 4. Cleaning up.
STEP: Cleaning up the webserver pods
STEP: Cleaning up the service

• [SLOW TEST:15.530 seconds]
Networking
/home/jay/gopath/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/networking.go:256
  should function for intra-pod communication
  /home/jay/gopath/src/github.com/GoogleCloudPlatform/kubernetes/test/e2e/networking.go:254
------------------------------
S
Ran 2 of 35 Specs in 15.961 seconds
SUCCESS! -- 2 Passed | 0 Failed | 0 Pending | 33 Skipped I0401 21:56:34.769721   21074 driver.go:94] All tests pass
[jay@rhbd kubernetes]$ git log | head -1
commit c316847c340884bd504a52175bf450d63fc9223d

@jayunit100
Copy link
Member Author

Actually wait. There is one more thing i want to fix in this rebase...........

@jayunit100 jayunit100 force-pushed the networking-test-reorder branch from c316847 to 60a7698 Compare April 2, 2015 02:15
@jayunit100
Copy link
Member Author

added some more cleanup around the comments for the internet connectivity/BeforeTest stuff.

@jayunit100 jayunit100 force-pushed the networking-test-reorder branch from 60a7698 to 2673351 Compare April 2, 2015 02:19
@jayunit100 jayunit100 closed this Apr 2, 2015
@jayunit100 jayunit100 force-pushed the networking-test-reorder branch from 2673351 to 1ff0a1e Compare April 2, 2015 02:31
@jayunit100
Copy link
Member Author

Moved here #6341 , something went wrong with the github's interpretation of this PR looks like. Sorry for the confusion ! This collided with another one that just went through...

@satnam6502 satnam6502 assigned piosz and unassigned satnam6502 Apr 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@piosz piosz

Labels
area/test-infra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@jayunit100 @bprashanth @googlebot @bgrant0607 @satnam6502 @piosz