Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #62462: Add private mount propagation to API. #62633

Merged
merged 2 commits into from
Apr 30, 2018
Merged

Automated cherry pick of #62462: Add private mount propagation to API. #62633

merged 2 commits into from
Apr 30, 2018

Conversation

jsafrane
Copy link
Member

Cherry pick of #62462 on release-1.10.

#62462: Add private mount propagation to API.

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Apr 16, 2018
@k8s-github-robot k8s-github-robot added do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API labels Apr 16, 2018
@jsafrane
Copy link
Member Author

/sig storage
/sig node

@k8s-ci-robot k8s-ci-robot added sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/node Categorizes an issue or PR as relevant to SIG Node. labels Apr 16, 2018
@jsafrane
Copy link
Member Author

@liggitt, @derekwaynecarr please lgtm/approve this cherry pick from node and API perspective.

@liggitt
Copy link
Member

liggitt commented Apr 16, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 16, 2018
@gnufied
Copy link
Member

gnufied commented Apr 16, 2018

cc @derekwaynecarr @Random-Liu for approval

@MaciekPytel MaciekPytel added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Apr 18, 2018
@jsafrane
Copy link
Member Author

/assign @derekwaynecarr @tallclair
for kubelet approval

@jsafrane jsafrane mentioned this pull request Apr 19, 2018
Merged
@jsafrane
Copy link
Member Author

/retest

@gnufied
Copy link
Member

gnufied commented Apr 23, 2018

/test pull-kubernetes-e2e-kops-aws

1 similar comment
@MaciekPytel
Copy link
Contributor

/test pull-kubernetes-e2e-kops-aws

@MaciekPytel
Copy link
Contributor

@derekwaynecarr @tallclair Can you take a look? This needs to be approved by tomorrow EOD if it is to be included in 1.10.2.

@MaciekPytel
Copy link
Contributor

/hold
Release branch is now frozen for 1.10.2 release. This will have to wait until the release.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 26, 2018
@jsafrane jsafrane mentioned this pull request Apr 27, 2018
Closed
@MaciekPytel
Copy link
Contributor

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 30, 2018
@derekwaynecarr
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: derekwaynecarr, jsafrane, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 30, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 18f4924 into kubernetes:release-1.10 Apr 30, 2018
@jsafrane jsafrane mentioned this pull request May 4, 2018
Closed
@luxas luxas mentioned this pull request Jun 4, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dchen1107 dchen1107 Awaiting requested review from dchen1107

@eparis eparis Awaiting requested review from eparis

@feiskyer feiskyer Awaiting requested review from feiskyer

@pmorie pmorie Awaiting requested review from pmorie

@resouer resouer Awaiting requested review from resouer

Assignees

@liggitt liggitt

@derekwaynecarr derekwaynecarr

@tallclair tallclair

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/api-change Categorizes issue or PR as related to adding, removing, or otherwise changing an API lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@jsafrane @liggitt @gnufied @MaciekPytel @derekwaynecarr @k8s-ci-robot @fejta-bot @k8s-github-robot @tallclair