Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Upload kubeadm Etcd Secrets when using SelfHosted StoreCertsInSecrets #61323

Closed
wants to merge 1 commit into from
Closed

[WIP] Upload kubeadm Etcd Secrets when using SelfHosted StoreCertsInSecrets #61323

wants to merge 1 commit into from

Conversation

stealthybox
Copy link
Member

@stealthybox stealthybox commented Mar 18, 2018 •
edited
Loading

What this PR does / why we need it:
This change uploads the APIServerEtcdClientCert, APIServerEtcdClientKey, and EtcdCACert to the cluster when using:
kubeadm init --feature-gates=SelfHosting=true,StoreCertsInSecrets=true

It fixes a bug where the selfhosted apiserver pod would fail to start because of the absence of these TLS artifacts.

Which issue(s) this PR fixes
Fixes #61322

Special notes for your reviewer:
StoreCertsInSecrets doesn't seem to be covered by e2e tests.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesn't merit a release note. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 18, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: stealthybox
To fully approve this pull request, please assign additional approvers.
We suggest the following additional approver: timothysc

Assign the PR to them by writing /assign @timothysc in a comment when ready.

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@stealthybox
Copy link
Member Author

/assign @andrewrynhard

@stealthybox
Copy link
Member Author

/test pull-kubernetes-e2e-kops-aws

@stealthybox
Copy link
Member Author

stealthybox commented Mar 18, 2018 •
edited
Loading

I got this to work locally after three tries.

this doesn't work yet, we need to add the etcd ca.crt as well -- we should consider uploading all the secrets -- also need to consider conditional codepath for external-etcd

Self-hosted controlplane is running and responding. 👍
The only static-pod running is etcd.

@stealthybox stealthybox changed the title Upload kubeadm APIServerEtcdClientCert Secret when using SelfHosted StoreCertsInSecrets [WIP] Upload kubeadm Etcd Secrets when using SelfHosted StoreCertsInSecrets Mar 18, 2018
@k8s-ci-robot k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Mar 18, 2018
@timothysc
Copy link
Member

@stealthybox ping me when this is ready and also nix the [WIP] prefix.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 17, 2018
@stealthybox
Copy link
Member Author

/remove-lifecycle stale

still an issue.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 17, 2018
@fabriziopandini fabriziopandini mentioned this pull request Aug 9, 2018
Closed
@stealthybox
Copy link
Member Author

We may deprecate this feature with self-hosting.

@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Nov 7, 2018
@fejta-bot
Copy link

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Dec 7, 2018
@fabriziopandini fabriziopandini mentioned this pull request Dec 29, 2018
Closed
@fejta-bot
Copy link

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

@k8s-ci-robot
Copy link
Contributor

@fejta-bot: Closed this PR.

In response to this:

Rotten issues close after 30d of inactivity.
Reopen the issue with /reopen.
Mark the issue as fresh with /remove-lifecycle rotten.

Send feedback to sig-testing, kubernetes/test-infra and/or fejta.
/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabriziopandini fabriziopandini Awaiting requested review from fabriziopandini

@mattmoyer mattmoyer Awaiting requested review from mattmoyer

Assignees

@andrewrynhard andrewrynhard

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

kubeadm: etcd certs missing in self-hosted deploy
5 participants
@stealthybox @k8s-ci-robot @timothysc @fejta-bot @andrewrynhard