Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent 1.9 e2es testing deprecated/removed features in 1.10 #61135

Merged
merged 2 commits into from
Mar 15, 2018
Merged

Prevent 1.9 e2es testing deprecated/removed features in 1.10 #61135

merged 2 commits into from
Mar 15, 2018

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Mar 13, 2018 •
edited
Loading

1.9 e2e tests get run against 1.10.0+ masters during upgrade tests. This version-gates testing deprecated features removed in 1.10

http://k8s-testgrid.appspot.com/sig-release-master-upgrade#gce-1.9-master-upgrade-master

Fixes #60769
Fixes #60767

@k8s-ci-robot
Copy link
Contributor

@liggitt: Adding do-not-merge/release-note-label-needed because the release note process has not been followed.

One of the following labels is required "release-note", "release-note-action-required", or "release-note-none".
Please see: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Mar 13, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Mar 13, 2018
@liggitt liggitt added this to the v1.9 milestone Mar 13, 2018
@liggitt liggitt added kind/bug Categorizes issue or PR as related to a bug. kind/upgrade-test-failure sig/testing Categorizes an issue or PR as relevant to SIG Testing. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. sig/release Categorizes an issue or PR as relevant to SIG Release. labels Mar 13, 2018
@liggitt
Copy link
Member Author

liggitt commented Mar 13, 2018

/kind cleanup

@k8s-ci-robot k8s-ci-robot added the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 13, 2018
@liggitt
Copy link
Member Author

liggitt commented Mar 13, 2018

/priority critical-urgent

@k8s-ci-robot k8s-ci-robot added the priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. label Mar 13, 2018
@liggitt liggitt removed the kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. label Mar 13, 2018
@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 13, 2018
@k8s-ci-robot k8s-ci-robot requested review from MrHohn and ncdc March 13, 2018 21:58
@liggitt liggitt force-pushed the version-gate-proxy-1.9 branch from 142d48c to 3a202d2 Compare March 13, 2018 23:25
@liggitt liggitt force-pushed the version-gate-proxy-1.9 branch from 3a202d2 to a50a211 Compare March 14, 2018 00:42
@liggitt
Copy link
Member Author

liggitt commented Mar 14, 2018

/release-note-none

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Mar 14, 2018
@k8s-github-robot
Copy link

[MILESTONENOTIFIER] Milestone Pull Request: Up-to-date for process

@floreks @jpbetz @liggitt @mikedanese

Pull Request Labels
  • sig/release sig/testing: Pull Request will be escalated to these SIGs if needed.
  • priority/critical-urgent: Never automatically move pull request out of a release milestone; continually escalate to contributor and SIG through all available channels.
  • kind/bug: Fixes a bug discovered during the current release.
Help

@liggitt
Copy link
Member Author

liggitt commented Mar 14, 2018

@floreks PTAL at ui e2e version gate
@mikedanese PTAL at proxy version gate

@jpbetz jpbetz added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Mar 14, 2018
@floreks
Copy link
Member

floreks commented Mar 14, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 14, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floreks, liggitt

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@floreks
Copy link
Member

floreks commented Mar 15, 2018

/test pull-kubernetes-e2e-gce

@liggitt
Copy link
Member Author

liggitt commented Mar 15, 2018

failed on #61230

@liggitt
Copy link
Member Author

liggitt commented Mar 15, 2018

stackdriver leak cleaned up in kubernetes/test-infra#7295
/retest

@liggitt
Copy link
Member Author

liggitt commented Mar 15, 2018

adding retest-not-required per discussion in #sig-release - https://kubernetes.slack.com/archives/C2C40FMNF/p1521142075000034

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 6cfd350 into kubernetes:release-1.9 Mar 15, 2018
This was referenced Mar 15, 2018
Closed
Closed
@liggitt liggitt mentioned this pull request Apr 23, 2018
Closed
@liggitt liggitt deleted the version-gate-proxy-1.9 branch April 22, 2019 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrHohn MrHohn Awaiting requested review from MrHohn

@ncdc ncdc Awaiting requested review from ncdc

Assignees

@jpbetz jpbetz

@mikedanese mikedanese

@floreks floreks

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
v1.9
Development

Successfully merging this pull request may close these issues.
6 participants
@liggitt @k8s-ci-robot @k8s-github-robot @floreks @jpbetz @mikedanese