Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove --service-account-private-key-file in v1.11 #60875

Merged
merged 1 commit into from
Mar 20, 2018
Merged

remove --service-account-private-key-file in v1.11 #60875

merged 1 commit into from
Mar 20, 2018

Conversation

ChiuWang
Copy link
Contributor

@ChiuWang ChiuWang commented Mar 7, 2018

kube-cloud-controller-manager flag --service-account-private-key-file is removed in v1.11

ref: #50289

Release note:

`kube-cloud-controller-manager` flag `--service-account-private-key-file` is removed in v1.11

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 7, 2018
@k8s-ci-robot k8s-ci-robot requested review from luxas and wlan0 March 7, 2018 09:19
@ChiuWang
Copy link
Contributor Author

ChiuWang commented Mar 8, 2018

/assign @liggitt

@CaoShuFeng
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Mar 8, 2018
@wlan0
Copy link
Member

wlan0 commented Mar 8, 2018

This looks good. Will defer to @liggitt to approve

@liggitt
Copy link
Member

liggitt commented Mar 8, 2018

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 8, 2018
@wlan0
Copy link
Member

wlan0 commented Mar 8, 2018

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: charrywanganthony, liggitt, wlan0

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 8, 2018
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

1 similar comment
@fejta-bot
Copy link

/retest
This bot automatically retries jobs that failed/flaked on approved PRs (send feedback to fejta).

Review the full test history for this PR.

Silence the bot with an /lgtm cancel comment for consistent failures.

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit d9008e0 into kubernetes:master Mar 20, 2018
@hectorhuertas hectorhuertas mentioned this pull request Apr 18, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wlan0 wlan0 wlan0 approved these changes

@luxas luxas Awaiting requested review from luxas

Assignees

@liggitt liggitt

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ChiuWang @CaoShuFeng @wlan0 @liggitt @k8s-ci-robot @fejta-bot @k8s-github-robot