Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Automated cherry pick of #59749: Detect CIDR IPv4 or IPv6 version to select nexthop #59868

Merged
merged 1 commit into from
Feb 25, 2018
Merged

Automated cherry pick of #59749: Detect CIDR IPv4 or IPv6 version to select nexthop #59868

merged 1 commit into from
Feb 25, 2018

Conversation

dims
Copy link
Member

@dims dims commented Feb 14, 2018 •
edited
Loading

Cherry pick of #59749 on release-1.9.

#59749: Detect CIDR IPv4 or IPv6 version to select nexthop

Fixing a bug in OpenStack cloud provider, where dual stack deployments (IPv4 and IPv6) did not work well when using kubenet as the network plugin.

@k8s-ci-robot k8s-ci-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Feb 14, 2018
@k8s-ci-robot k8s-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 14, 2018
@k8s-github-robot k8s-github-robot added the do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. label Feb 14, 2018
@zioproto
Copy link
Member 

Issue #59421 was closed: the Openstack deployment with dual stack (IPv4 and IPv6) nodes and network-plugin=kubenet is now working properly.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Feb 14, 2018
@dims
Copy link
Member Author

dims commented Feb 15, 2018

@mbohlool can you please approve this cherry pick for 1.9?

/sig openstack

@k8s-ci-robot k8s-ci-robot added the area/provider/openstack Issues or PRs related to openstack provider label Feb 15, 2018
@hogepodge
Copy link

/lgtm /approve

dklyle
dklyle reviewed Feb 15, 2018
View reviewed changes
Copy link

@dklyle dklyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

@dklyle: changing LGTM is restricted to assignees, and only kubernetes org members may be assigned issues.

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@mbohlool
Copy link
Contributor

Would you please update the release note to a more user-facing note? no need to refer issue number in the release note itself as it will have a link to the issue automatically. I would suggest something like Fixing a bug in ... where ...

@dims
Copy link
Member Author

dims commented Feb 16, 2018

thanks @mbohlool Done!

@zioproto
Copy link
Member

@dims @mbohlool is anything else missing for this patch to be merged in the v1.9 release? I ask because we are going to production with Kubernetes as soon as this patch is available in an official release. Thanks for your help.

@mbohlool
Copy link
Contributor

The release note needed to go into the parent PR. I've already done that. PR LGTM.

@mbohlool mbohlool added cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. and removed do-not-merge/cherry-pick-not-approved Indicates that a PR is not yet approved to merge into a release branch. labels Feb 21, 2018
@NickrenREN
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 25, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, dklyle, hogepodge, NickrenREN

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

/test all [submit-queue is verifying that this PR is safe to merge]

@zioproto
Copy link
Member

/test pull-kubernetes-unit

@k8s-github-robot
Copy link

Automatic merge from submit-queue.

@k8s-github-robot k8s-github-robot merged commit 77487e4 into kubernetes:release-1.9 Feb 25, 2018
@zioproto zioproto mentioned this pull request Mar 15, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dklyle dklyle dklyle left review comments

@anguslees anguslees Awaiting requested review from anguslees

@NickrenREN NickrenREN Awaiting requested review from NickrenREN

Assignees

@NickrenREN NickrenREN

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/provider/openstack Issues or PRs related to openstack provider cherry-pick-approved Indicates a cherry-pick PR into a release branch has been approved by the release branch manager. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@dims @zioproto @hogepodge @k8s-ci-robot @mbohlool @NickrenREN @k8s-github-robot @dklyle