Add the ability to watch fields of a replication controller #5971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Adhoc and unittest testing done, e2e still running. |
bprashanth
changed the title
| switch label { | ||
| case "name": | ||
| return "name", value, nil | ||
| case "CurrentState.Replicas": |
There was a problem hiding this comment.
"currentState.replicas" for consistency?
There was a problem hiding this comment.
I was going for consistency with pods, still think currentState is better?
There was a problem hiding this comment.
Yeah pods is unfortunately wrong, take a look at events--it's lowercase.
bprashanth
force-pushed
the
rc_watch_fields
branch
from
0144d87 to
b0068d0
Compare
|
PTAL |
|
LGTM - shippable looks like a flake |
lavalamp
added
the
lgtm
|
e2e done |
|
Looking at travis failure, which seems to be for a different apiversion |
|
This should be good to go, the failures were flakes and didn't repro locally or on the rerun |
|
All checks are green so merging. |
piosz
added a commit
that referenced
this pull request
Mar 27, 2015
Add the ability to watch fields of a replication controller
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this change clients can watch on a specific controller's status.replicas without polling pods/rcs. This is needed for #5745 and #5884.