Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor volume util files #59310

Merged
merged 7 commits into from
Feb 27, 2018
Merged

refactor volume util files #59310

merged 7 commits into from
Feb 27, 2018

Conversation

wackxu
Copy link
Contributor

@wackxu wackxu commented Feb 3, 2018

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes # #44460

Special notes for your reviewer:
/assign @jsafrane @msau42

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Feb 3, 2018
@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 3, 2018
@lichuqiang
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot removed the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 3, 2018
@wackxu wackxu force-pushed the refvolutil branch 7 times, most recently from 31114d7 to 3c9b9fb Compare February 5, 2018 07:19
@msau42
Copy link
Member

msau42 commented Feb 27, 2018

/lgtm
/assign @thockin

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 27, 2018
@saad-ali saad-ali added this to the v1.10 milestone Feb 27, 2018
@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2018
@wackxu
Copy link
Contributor Author

wackxu commented Feb 27, 2018

@msau42 @jsafrane @thockin Make another rebase and the CI is green again, PTAL

@jsafrane
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2018
@jsafrane
Copy link
Member

aehm, another conflict

@k8s-github-robot k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2018
@wackxu
Copy link
Contributor Author

wackxu commented Feb 27, 2018

/retest

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Feb 27, 2018 •
edited
Loading

@wackxu: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-e2e-kubeadm-gce-canary 2858c16a0b84ef18333e833f43ecd5d512d2c062 link /test pull-kubernetes-e2e-kubeadm-gce-canary

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@jsafrane
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 27, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, msau42, thockin, wackxu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-github-robot
Copy link

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

@k8s-github-robot k8s-github-robot merged commit f4472b1 into kubernetes:master Feb 27, 2018
@jsafrane
Copy link
Member

Finally!
@wackxu, thanks for your patience.

@wackxu wackxu deleted the refvolutil branch February 28, 2018 01:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brendandburns brendandburns Awaiting requested review from brendandburns

@chrislovecnm chrislovecnm Awaiting requested review from chrislovecnm

@copejon copejon Awaiting requested review from copejon

@FengyunPan FengyunPan Awaiting requested review from FengyunPan

@foxish foxish Awaiting requested review from foxish

@gnufied gnufied Awaiting requested review from gnufied

@humblec humblec Awaiting requested review from humblec

@ivan4th ivan4th Awaiting requested review from ivan4th

@jeffvance jeffvance Awaiting requested review from jeffvance

@jingxu97 jingxu97 Awaiting requested review from jingxu97

@jsafrane jsafrane Awaiting requested review from jsafrane

@justinsb justinsb Awaiting requested review from justinsb

@msau42 msau42 Awaiting requested review from msau42

@mtanino mtanino Awaiting requested review from mtanino

@mtaufen mtaufen Awaiting requested review from mtaufen

Assignees

@jsafrane jsafrane

@thockin thockin

@msau42 msau42

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.
Projects
None yet
Milestone
v1.10
Development

Successfully merging this pull request may close these issues.
8 participants
@wackxu @lichuqiang @msau42 @jsafrane @thockin @k8s-ci-robot @k8s-github-robot @saad-ali