Use pause manifest image #59056

mkumatag · 2018-01-30T18:08:49Z

What this PR does / why we need it:
As pause manifest code is merged part of #57723, now its time to remove all architecture-dependent pause imagename.
Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #

Special notes for your reviewer:

Release note:

NONE

ixdy · 2018-01-31T01:10:00Z

/retest

Is there a minimum docker version needed for this to work properly?

mkumatag · 2018-01-31T12:28:57Z

/retest

mkumatag · 2018-01-31T16:08:16Z

@ixdy fat manifest pushed to docker via moby/moby#18785 in docker 1.10.0 release, so minimum version we need is docker 1.10.0 release.

luxas

LGTM

luxas · 2018-02-08T10:43:13Z

pkg/kubelet/dockershim/docker_sandbox.go

@@ -36,7 +36,7 @@ import (
 )

 const (
-	defaultSandboxImage = "gcr.io/google_containers/pause-amd64:3.1"


can this start use test/utils/image instead?

I'm little hesitant to use this one because it is completely outside of pkg/ package.

I agree with @mkumatag - I think we should avoid dependencies from pkg/ -> test/.

Fair enough - I'm fine with that :)

mkumatag · 2018-02-09T04:50:09Z

Resolved the conflict and pushed it back, @luxas @ixdy PTAL.

ixdy · 2018-02-14T00:18:50Z

test/utils/image/manifest.go

@@ -84,7 +84,7 @@ var (
 	NoSnatTestProxy          = ImageConfig{e2eRegistry, "no-snat-test-proxy", "1.0", true}
 	NWayHTTP                 = ImageConfig{e2eRegistry, "n-way-http", "1.0", true}
 	// When these values are updated, also update cmd/kubelet/app/options/container_runtime.go


per this comment, I think you need to update cmd/kubelet/app/options/container_runtime.go?

kubernetes/cmd/kubelet/app/options/container_runtime.go

Lines 36 to 40 in 6590ea6

var (

defaultPodSandboxImage = defaultPodSandboxImageName +

"-" + runtime.GOARCH + ":" +

defaultPodSandboxImageVersion

)

fixed the review comment, PTAL latest commit.

ixdy · 2018-02-20T23:32:21Z

test/integration/framework/util.go

-}
-
-// GetPauseImageName fetches the pause image name for the same architecture as the apiserver.
+// GetPauseImageName returns the pause image name with proper version
 func GetPauseImageName(c clientset.Interface) string {


minor not: his probably doesn't need to take c anymore.

after removing that c this function is dup of function from manifest.go file, so I consolidated all the functions into one and refactored the code a bit. PTAL at latest commits.

ixdy · 2018-02-20T23:32:30Z

/lgtm

ixdy · 2018-02-21T16:44:34Z

/lgtm

ixdy · 2018-02-21T16:47:24Z

/assign @vishh

mkumatag · 2018-02-24T01:37:24Z

@vishh please help me getting this PR into this release!

mkumatag · 2018-02-26T05:07:39Z

/test pull-kubernetes-unit

mkumatag · 2018-04-02T08:50:08Z

@vishh can you PTAL at this PR?

mkumatag · 2018-04-06T03:55:44Z

@kubernetes/sig-node-pr-reviews can someone please help me reviewing this code?

resouer · 2018-04-06T05:06:02Z

Could you please squash the commits?

I will kindly ask @kubernetes/sig-node-pr-reviews for approve for you

mkumatag · 2018-04-06T05:32:12Z

@resouer done.! Thanks

resouer · 2018-04-06T05:38:12Z

/lgtm

vishh · 2018-04-06T18:35:47Z

/approve

k8s-ci-robot · 2018-04-06T18:35:54Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ixdy, mkumatag, resouer, vishh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~cmd/kubelet/OWNERS~~ [vishh]
~~hack/OWNERS~~ [ixdy,vishh]
~~pkg/kubelet/OWNERS~~ [vishh]
~~test/OWNERS~~ [ixdy,vishh]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-github-robot · 2018-04-06T19:18:48Z

/test all [submit-queue is verifying that this PR is safe to merge]

k8s-github-robot · 2018-04-06T20:14:13Z

Automatic merge from submit-queue. If you want to cherry-pick this change to another branch, please follow the instructions here.

k8s-ci-robot requested review from derekwaynecarr, gmarek, ixdy and lavalamp January 30, 2018 18:08

k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 30, 2018

mkumatag force-pushed the pause_manifest branch from 3e1ce17 to 58feb3e Compare January 31, 2018 16:38

luxas approved these changes Feb 8, 2018

View reviewed changes

k8s-github-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 8, 2018

luxas approved these changes Feb 8, 2018

View reviewed changes

mkumatag force-pushed the pause_manifest branch from 58feb3e to 3b12849 Compare February 9, 2018 04:48

k8s-github-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 9, 2018

mkumatag force-pushed the pause_manifest branch 2 times, most recently from e40ef26 to 7e6a516 Compare February 9, 2018 04:53

mkumatag mentioned this pull request Feb 9, 2018

Manifest list for kubernetes images #57869

Closed

11 tasks

ixdy reviewed Feb 14, 2018

View reviewed changes

ixdy reviewed Feb 20, 2018

View reviewed changes

k8s-ci-robot assigned ixdy Feb 20, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 20, 2018

mkumatag force-pushed the pause_manifest branch from 56f2b70 to 1a5d184 Compare February 21, 2018 08:08

k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Feb 21, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 21, 2018

k8s-ci-robot assigned vishh Feb 21, 2018

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 26, 2018

mkumatag force-pushed the pause_manifest branch from 0c034c4 to a3ab03b Compare February 26, 2018 04:13

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 26, 2018

k8s-github-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 26, 2018

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Mar 1, 2018

k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Apr 6, 2018

mkumatag force-pushed the pause_manifest branch from a3ab03b to b235d88 Compare April 6, 2018 04:07

k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 6, 2018

Use pause manifest image

1bb810e

mkumatag force-pushed the pause_manifest branch from b235d88 to 1bb810e Compare April 6, 2018 05:31

k8s-ci-robot assigned resouer Apr 6, 2018

k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 6, 2018

k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 6, 2018

k8s-github-robot merged commit 489178d into kubernetes:master Apr 6, 2018

mkumatag deleted the pause_manifest branch April 7, 2018 04:12

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use pause manifest image #59056

Use pause manifest image #59056

mkumatag commented Jan 30, 2018 •

edited

Loading

ixdy commented Jan 31, 2018

mkumatag commented Jan 31, 2018

mkumatag commented Jan 31, 2018

luxas left a comment

luxas Feb 8, 2018

mkumatag Feb 8, 2018

ixdy Feb 8, 2018

luxas Feb 8, 2018

mkumatag commented Feb 9, 2018

ixdy Feb 14, 2018

mkumatag Feb 14, 2018

ixdy Feb 20, 2018

mkumatag Feb 21, 2018

ixdy commented Feb 20, 2018

ixdy commented Feb 21, 2018

ixdy commented Feb 21, 2018

mkumatag commented Feb 24, 2018

mkumatag commented Feb 26, 2018

mkumatag commented Apr 2, 2018

mkumatag commented Apr 6, 2018

resouer commented Apr 6, 2018

mkumatag commented Apr 6, 2018

resouer commented Apr 6, 2018 •

edited

Loading

vishh commented Apr 6, 2018

k8s-ci-robot commented Apr 6, 2018

k8s-github-robot commented Apr 6, 2018

k8s-github-robot commented Apr 6, 2018

	var (
	defaultPodSandboxImage = defaultPodSandboxImageName +
	"-" + runtime.GOARCH + ":" +
	defaultPodSandboxImageVersion
	)

Use pause manifest image #59056

Use pause manifest image #59056

Conversation

mkumatag commented Jan 30, 2018 • edited Loading

ixdy commented Jan 31, 2018

mkumatag commented Jan 31, 2018

mkumatag commented Jan 31, 2018

luxas left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mkumatag commented Feb 9, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ixdy commented Feb 20, 2018

ixdy commented Feb 21, 2018

ixdy commented Feb 21, 2018

mkumatag commented Feb 24, 2018

mkumatag commented Feb 26, 2018

mkumatag commented Apr 2, 2018

mkumatag commented Apr 6, 2018

resouer commented Apr 6, 2018

mkumatag commented Apr 6, 2018

resouer commented Apr 6, 2018 • edited Loading

vishh commented Apr 6, 2018

k8s-ci-robot commented Apr 6, 2018

k8s-github-robot commented Apr 6, 2018

k8s-github-robot commented Apr 6, 2018

mkumatag commented Jan 30, 2018 •

edited

Loading

resouer commented Apr 6, 2018 •

edited

Loading