Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete pod_cache and rely on updating pod status by kublet. #5854

Merged
merged 1 commit into from
Mar 25, 2015
Merged

Delete pod_cache and rely on updating pod status by kublet. #5854

merged 1 commit into from
Mar 25, 2015

Conversation

fgrzadkowski
Copy link
Contributor

@davidopp @bgrant0607 @lavalamp

This fixes #2947. It is also related to #2726

@davidopp
Copy link
Member

LGTM

Am I correct in understanding that this is the last in the following sequence of PRs: #5205, #5555, #5624?

@davidopp
Copy link
Member

Please check/fix test issue. (Shippable failed, Travis is just very slow right now.)

@fgrzadkowski
Copy link
Contributor Author

@davidopp Yes, this is the last PR in the sequence (except that I think you've meant #5714 not #5624)

I checked shippable and it failed on some initial step not related with kubernetes itself (docker pull). I have restarted it - hopefully it'll be green this time.

@fgrzadkowski
Copy link
Contributor Author

One of the shippable runs failed, the other succeeded. Looks like a flake, but I'll take a look tomorrow.

@bgrant0607 bgrant0607 mentioned this pull request Mar 25, 2015
Closed
@fgrzadkowski fgrzadkowski mentioned this pull request Mar 25, 2015
Closed
@fgrzadkowski
Copy link
Contributor Author

FYI @bprashanth

@fgrzadkowski
Copy link
Contributor Author

Rebased. e2e test passes.

@fgrzadkowski
Copy link
Contributor Author

It seems there is a bug in integration tests #5872. I'm sending a separate PR to fix it.

saad-ali added a commit that referenced this pull request Mar 25, 2015
@saad-ali
Merge pull request #5854 from fgrzadkowski/delete_pod_cache
1f50bd2 
Delete pod_cache and rely on updating pod status by kublet.
@saad-ali saad-ali merged commit 1f50bd2 into kubernetes:master Mar 25, 2015
@dchen1107 dchen1107 mentioned this pull request Mar 27, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@davidopp davidopp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Invalidate pod state cache before events from kubelet are propagated
4 participants
@fgrzadkowski @davidopp @googlebot @saad-ali