Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix '--user' flag conflict in create rolebinding command #57986

Closed
wants to merge 1 commit into from
Closed

fix '--user' flag conflict in create rolebinding command #57986

wants to merge 1 commit into from

Conversation

Lion-Wei
Copy link

@Lion-Wei Lion-Wei commented Jan 9, 2018

What this PR does / why we need it:

--user is kubectl global flag, but kubectl create rolebinding and other command also have this flag with other meaning, that will result in Kubectl doesn't respect --user parameter.

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes kubernetes/kubectl#188

Special notes for your reviewer:

Change --user flag in kubectl create clusterrolebinding and other command to --roleuser.

Release note:

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Jan 9, 2018
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Lion-Wei
We suggest the following additional approver: brendandburns

Assign the PR to them by writing /assign @brendandburns in a comment when ready.

Associated issue: #188

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these OWNERS Files:

You can indicate your approval by writing /approve in a comment
You can cancel your approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Jan 9, 2018
@Lion-Wei
Copy link
Author

Lion-Wei commented Jan 9, 2018

/cc @apelisse
@mpashka
/sig cli
/kind bug

@k8s-ci-robot k8s-ci-robot requested a review from apelisse January 9, 2018 03:23
@k8s-ci-robot k8s-ci-robot added sig/cli Categorizes an issue or PR as relevant to SIG CLI. kind/bug Categorizes issue or PR as related to a bug. labels Jan 9, 2018
@apelisse
Copy link
Member

apelisse commented Jan 9, 2018

/ok-to-test

Discussion is happening on the issue:
/hold

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jan 9, 2018
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Jan 9, 2018 •
edited
Loading

@Lion-Wei: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
pull-kubernetes-verify bbe7e0e link /test pull-kubernetes-verify
pull-kubernetes-unit bbe7e0e link /test pull-kubernetes-unit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@liggitt
Copy link
Member

liggitt commented Jan 15, 2018

I don't think we'll change the command at this point, it would break too many uses
/close

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@apelisse apelisse Awaiting requested review from apelisse

Assignees

@liggitt liggitt

@ghodss ghodss

@rootfs rootfs

Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/bug Categorizes issue or PR as related to a bug. release-note-none Denotes a PR that doesn't merit a release note. sig/cli Categorizes an issue or PR as relevant to SIG CLI. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Kubectl doesn't respect --user parameter when execution create clusterrolebinding
6 participants
@Lion-Wei @k8s-ci-robot @apelisse @liggitt @ghodss @rootfs